Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary easyblock already adds top level directory to PATH, so no need to do it in the Stata easyblock #3307

Merged
merged 1 commit into from Apr 17, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Apr 15, 2024

The top level directory is already added in the Binary easyblock: https://github.com/easybuilders/easybuild-easyblocks/blob/develop/easybuild/easyblocks/generic/binary.py#L159

WARNING: Suppressed adding the following path(s) to $PATH of the module as they were already added:
['']

@branfosj branfosj added this to the release after 4.9.1 milestone Apr 15, 2024
@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Stata-17.rev2023-01-10.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/9f31f6ac12f1de510ee178268f9c7764 for a full test report.

@branfosj
Copy link
Member Author

And checking, the module file contains

prepend_path("PATH", root)

@branfosj branfosj changed the title Binary easyblock already adds top level directory, so no need to do it in the Stata easyblock Binary easyblock already adds top level directory to PATH, so no need to do it in the Stata easyblock Apr 17, 2024
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Apr 17, 2024

Going in, thanks @branfosj!

@smoors smoors merged commit 98ee90e into easybuilders:develop Apr 17, 2024
47 checks passed
@branfosj branfosj deleted the stata branch April 17, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants