-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch ctypes
for Python installations when filtering LD_LIBRARY_PATH
+ fix path to ldconfig
when using alternate sysroot
#3352
Conversation
ctypes
for Python installations when filtering LD_LIBRARY_PATH
ctypes
for Python installations when filtering LD_LIBRARY_PATH
and add testing by default for recent versions
Patching seems to work (edit: but not as originally intended):
|
@boegelbot please test @ jsc-zen3 EB_ARGS="--trace Python-3.10.4-GCCcore-11.3.0-bare.eb Python-3.10.8-GCCcore-12.2.0-bare.eb Python-3.11.2-GCCcore-12.2.0-bare.eb" |
@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2154930449 processed Message to humans: this is just bookkeeping information for me, |
@boegelbot please test @ generoso EB_ARGS="--trace Python-3.10.4-GCCcore-11.3.0-bare.eb Python-3.10.8-GCCcore-12.2.0-bare.eb Python-3.11.2-GCCcore-12.2.0-bare.eb" |
@ocaisa: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2154994489 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
@boegelbot please test @ jsc-zen3 EB_ARGS="--trace Python-3.11.3-GCCcore-12.3.0.eb Python-3.11.5-GCCcore-13.2.0.eb Python-3.10.4-GCCcore-11.3.0-bare.eb Python-3.10.8-GCCcore-12.2.0-bare.eb Python-3.11.2-GCCcore-12.2.0-bare.eb" |
@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2155065309 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
@boegelbot please test @ generoso EB_ARGS="--trace Python-3.11.3-GCCcore-12.3.0.eb Python-3.11.5-GCCcore-13.2.0.eb Python-3.10.4-GCCcore-11.3.0-bare.eb Python-3.10.8-GCCcore-12.2.0-bare.eb Python-3.11.2-GCCcore-12.2.0-bare.eb" |
@ocaisa: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2155132179 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) |
Ok, the latest commit fixes the problem:
However, I'm still seeing if there is a better way |
ctypes
for Python installations when filtering LD_LIBRARY_PATH
and add testing by default for recent versionsctypes
for Python installations when filtering LD_LIBRARY_PATH
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
This should also fix the scenario described in #2183 (I think) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
In case anyone wants to replicate my tests, I ran with an
Then build with:
(modify the I've done similar manual tests as @ocaisa in #3352 (comment) , see for details see https://gitlab.com/eessi/support/-/issues/77, specifically how it picks up on the correct I'm happy with this PR as it is. @ocaisa let me know if you are too, then I'll merge it (we both worked on it, but if we both agree with the current form, it's not breaking the 4-eyes principle :)). |
@casparvl I think this is good to go, successful test with EESSI/software-layer#655 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
ctypes
for Python installations when filtering LD_LIBRARY_PATH
ctypes
for Python installations when filtering LD_LIBRARY_PATH
+ fix path to ldconfig
when using alternate sysroot
ctypes
relies onLD_LIBRARY_PATH
and doesn't respect rpath linking, this is a workaround for the EasyBuild context for this setup.