add easyblock for binutils (REVIEW) #907
Conversation
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1951/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
| def configure_step(self): | ||
| """Custom configuration procedure for binutils: statically link to zlib, configure options.""" | ||
|
|
||
| libdirs = ['/lib', '/lib64', '/usr/lib', '/usr/lib64', '/usr/lib/x86_64-linux-gnu/'] |
There was a problem hiding this comment.
check if /lib and /usr/lib are the same and only add one if needed (same for lib64)
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1952/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
👍 |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1954/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
… building of shared libs and ld.gold for recent binutils versions
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1957/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
boegel
changed the title
|
It looks fine. probably a good use of RPATH somewhere in here. The sanity check is probably ok for now, but it would be better to have the sanity check I need for RPATH so we can check in a more robust way. this is all non-blocking though, just ideas for the future. |
|
should be good to go now, see test reports in easybuilders/easybuild-easyconfigs#3006 (comment) (existing binutils easyconfigs) and easybuilders/easybuild-easyconfigs#2524 (comment) (binutils 2.26) |
|
👍 |
see also discussion in easybuilders/easybuild-easyconfigs#2524
cc @wpoely86, @ocaisa