enhance Qt easyblock to support Qt3 #944
Merged
+21
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| platform = 'linux-icc' | ||
| # fix -fPIC flag (-KPIC is not correct for recent Intel compilers) | ||
| qmake_conf = os.path.join('mkspecs', platform, 'qmake.conf') | ||
| apply_regex_substitutions(qmake_conf, [('-KPIC', '-fPIC')]) |
There was a problem hiding this comment.
does this have a clean error is the file does not exist?
There was a problem hiding this comment.
>>> from easybuild.tools.filetools import apply_regex_substitutions
>>> apply_regex_substitutions('/tmp/sadfghmythergsdfdadgh', [])
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "easybuild/tools/filetools.py", line 747, in apply_regex_substitutions
for line in fileinput.input(path, inplace=1, backup='.orig.eb'):
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/fileinput.py", line 254, in next
line = self.readline()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/fileinput.py", line 325, in readline
os.rename(self._filename, self._backupfilename)
OSError: [Errno 2] No such file or directory
If you want to change that, it should be tackled in apply_regex_substitutions itself imho, not in this easyblock.
There was a problem hiding this comment.
true, open a PR for it 😁
The error should tell which file it's not finding.
There was a problem hiding this comment.
|
Thanks for the review @wpoely86! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.