Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBLAS is not using provided LAPACK sources #1050

Closed
boegel opened this issue Aug 28, 2014 · 8 comments
Closed

OpenBLAS is not using provided LAPACK sources #1050

boegel opened this issue Aug 28, 2014 · 8 comments
Milestone

Comments

@boegel
Copy link
Member

boegel commented Aug 28, 2014

The OpenBLAS 0.2.8 and 0.2.9 easyconfigs we're using now are not using the provided LAPACK sources, but are resorting to the lapack-netlib included in the OpenBLAS sources.

For OpenBLAS 0.2.9 and more recent this is not a big problem, since the LAPACK included in the sources matching the one we're passing it (3.5.0), see https://github.com/xianyi/OpenBLAS/blob/develop/lapack-netlib/README .

@boegel
Copy link
Member Author

boegel commented Aug 28, 2014

Maybe we should just stop trying to provide our own LAPACK source tarball to OpenBLAS?

@akesandgren
Copy link
Contributor

Still is still a problem for newer openblas/lapack combos, like openblas-0.2.18-lapack-3.6.1 where openblas contains lapack-3.6.0
I have a fix for this and will send a PR soon

@akesandgren
Copy link
Contributor

PR 3700 added

@akesandgren
Copy link
Contributor

akesandgren commented Oct 22, 2016

Unfortunately the patch in PR #3700 is not good enough to allow me to add patches onto LAPACK after it has been unpacked, which is needed to fix some compile time bugs...

@akesandgren
Copy link
Contributor

I'll withdraw that PR. I really need to get this done the correct way to solve all build problems.

@boegel
Copy link
Member Author

boegel commented Oct 22, 2016

@akesandgren thanks for looking into this!

@akesandgren
Copy link
Contributor

akesandgren commented Oct 22, 2016

Made a new PR 3701 that handles this in a much better way, and doesn't include patches.

It also makes it possible to add patches on to of the unpacked lapack to deal with compiler problems (and lapack bugs).

I'll start generating more PR for those problems, if this one gets accepted.

@boegel
Copy link
Member Author

boegel commented Nov 14, 2016

fixed by #3701 & #3795

@boegel boegel closed this as completed Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants