-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenBLAS is not using provided LAPACK sources #1050
Comments
Maybe we should just stop trying to provide our own LAPACK source tarball to OpenBLAS? |
Still is still a problem for newer openblas/lapack combos, like openblas-0.2.18-lapack-3.6.1 where openblas contains lapack-3.6.0 |
PR 3700 added |
Unfortunately the patch in PR #3700 is not good enough to allow me to add patches onto LAPACK after it has been unpacked, which is needed to fix some compile time bugs... |
I'll withdraw that PR. I really need to get this done the correct way to solve all build problems. |
@akesandgren thanks for looking into this! |
Made a new PR 3701 that handles this in a much better way, and doesn't include patches. It also makes it possible to add patches on to of the unpacked lapack to deal with compiler problems (and lapack bugs). I'll start generating more PR for those problems, if this one gets accepted. |
The OpenBLAS 0.2.8 and 0.2.9 easyconfigs we're using now are not using the provided LAPACK sources, but are resorting to the
lapack-netlib
included in the OpenBLAS sources.For OpenBLAS 0.2.9 and more recent this is not a big problem, since the LAPACK included in the sources matching the one we're passing it (3.5.0), see https://github.com/xianyi/OpenBLAS/blob/develop/lapack-netlib/README .
The text was updated successfully, but these errors were encountered: