Make OpenBLAS use the LAPACK version specified in the easyconfig. #3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OpenBLAS Makefile only handles large.tgz and timing.tgz and ignores lapack-x.y.z.tgz. We need to manually unpack the lapack-x.y.z specified in the easyconfig. Doing it this way makse it possible to add patches on top of the unpacked lapack version, which is neccesary to deal with various compiler problems.
boegel
reviewed
Oct 23, 2016
| @@ -16,7 +18,7 @@ large_src = 'large.tgz' | |||
| timing_src = 'timing.tgz' | |||
| sources = [ | |||
| 'v%(version)s.tar.gz', | |||
| lapack_src, | |||
| (lapack_src, 'mv %s/lapack-netlib %s/lapack-netlib.old; mkdir %s/lapack-netlib; tar -C %s/lapack-netlib --strip-components=1 -zxf %%s' % (obv, obv, obv, obv)), | |||
There was a problem hiding this comment.
@akesandgren I would try and shorten this a bit (lines should be < 120 chars long); also, I see no point in keeping lapack-netlib.old around...
lapack_unpack_cmd = "tar -C lapack-netlib --strip-components=1 -zxf %%s"
sources = [
'v%(version)s.tar.gz',
(lapack_src, "cd %%(name)s-%%(version)s; rm -rf lapack-netlib/*; %s; cd -" % lapack_unpack_cmd
...
Also don't keep a copy of the old lapack-netlib.
|
Dropped saving of old lapack-netlib and made a more easily readable lapack_unpack_cmd. |
This was referenced Nov 14, 2016
|
merged via #3795 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenBLAS Makefile only handles large.tgz and timing.tgz and ignores
lapack-x.y.z.tgz. We need to manually unpack the lapack-x.y.z specified
in the easyconfig.
Doing it this way makes it possible to add patches on top of the
unpacked lapack version, which is neccesary to deal with various
compiler problems.
This solves easyconfig issue #1050.