Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lang}[GCCcore/9.3.0] SBCL v2.0.9 #11413

Merged
merged 1 commit into from Oct 2, 2020

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Oct 1, 2020

(created using eb --new-pr)

@lexming lexming added the new label Oct 1, 2020
@lexming
Copy link
Contributor Author

lexming commented Oct 1, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node379.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/6986e30b0b788e21b62053202ed2dd4f for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Oct 1, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node101.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/f1ad5fb663dcc8da3fc0953e99c83503 for a full test report.

@lexming lexming added this to the 4.x milestone Oct 1, 2020
@smoors
Copy link
Contributor

smoors commented Oct 1, 2020

this uses ConfigureMake, but skips the configure step and has custom build and install commands.
so it's not actually doing ConfigureMake anymore, which is ok for me, but I wonder why you're not using CmdCp instead?

@lexming
Copy link
Contributor Author

lexming commented Oct 1, 2020

The problem with CmdCp is that it needs files_to_copy, but in this case there are none because the software provides an installation script.

@smoors
Copy link
Contributor

smoors commented Oct 2, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on generoso

PR test command 'EB_PR=11413 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11413 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8000

Test results coming soon (I hope)...

- notification for comment with ID 702580630 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@smoors
Copy link
Contributor

smoors commented Oct 2, 2020

ok, another option could have been this: files_to_copy = [([''], '')]
but with ConfigureMake there are separate of build and install steps, I prefer that.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso-x-3 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/0ca32971bcddb5cf8ba2ebc185a68a25 for a full test report.

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors modified the milestones: 4.x, next release (4.3.1) Oct 2, 2020
@smoors
Copy link
Contributor

smoors commented Oct 2, 2020

Going in, thanks @lexming!

@smoors smoors merged commit 7edeb02 into easybuilders:develop Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants