Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing moduleclass in UCLUST easyconfig #11477

Merged
merged 2 commits into from Feb 19, 2021
Merged

add missing moduleclass in UCLUST easyconfig #11477

merged 2 commits into from Feb 19, 2021

Conversation

FokkeDijkstra
Copy link
Contributor

(created using eb --new-pr)

Micket
Micket previously requested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also fix the urls to https so that the test suite is happy?

@Micket Micket added this to the next release (4.3.1) milestone Oct 13, 2020
@Micket Micket added the bug fix label Oct 13, 2020
@lexming lexming changed the title Added missing moduleclass to the easyconfig {bio}[SYSTEM] UCLUST v1.2.22q-i86linux64: add missing moduleclass Oct 13, 2020
@boegel boegel modified the milestones: 4.3.1 (next release), 4.3.2 Oct 26, 2020
@verdurin
Copy link
Member

verdurin commented Nov 2, 2020

@FokkeDijkstra any update on this one?

@FokkeDijkstra
Copy link
Contributor Author

This slipped from my attention. I will update the PR.

@boegel boegel modified the milestones: 4.3.2 (next release), 4.4.0 Dec 8, 2020
@boegel
Copy link
Member

boegel commented Feb 19, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3600.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/22a2738c0bde31f61a986668965833b3 for a full test report.

boegel
boegel approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title {bio}[SYSTEM] UCLUST v1.2.22q-i86linux64: add missing moduleclass add missing moduleclass in UCLUST easyconfig Feb 19, 2021
@easybuilders easybuilders deleted a comment from boegelbot Feb 19, 2021
@boegel boegel dismissed Micket’s stale review February 19, 2021 17:20

https URLs fixed

@boegel
Copy link
Member

boegel commented Feb 19, 2021

Going in, thanks @FokkeDijkstra!

@boegel boegel merged commit f196860 into easybuilders:develop Feb 19, 2021
@FokkeDijkstra FokkeDijkstra deleted the 20201013143753_new_pr_UCLUST1222q branch April 26, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

@Micket Micket Micket left review comments

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.3.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FokkeDijkstra @verdurin @boegel @Micket