Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch for TensorFlow 2.3.1 to fix installation on Arm64 #11614

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 4, 2020

(created using eb --new-pr)

boegel added a commit to boegel/software-layer that referenced this pull request Nov 4, 2020
@boegel boegel added bug fix EESSI Related to EESSI project labels Nov 4, 2020
@boegel boegel added this to the 4.3.2 milestone Nov 4, 2020
@boegel
Copy link
Member Author

boegel commented Nov 4, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11614 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11614 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9695

Test results coming soon (I hope)...

- notification for comment with ID 721836290 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member Author

boegel commented Nov 4, 2020

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3403.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/b5bc5598acc452b4e15870fee1e76771 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/ed5344a6123430658aa0620cd7e8f333 for a full test report.

@verdurin
Copy link
Member

verdurin commented Nov 5, 2020

@boegel do we need a build report from an ARM64 box to check the fix works, as well as that it doesn't break on other architectures?

@akesandgren
Copy link
Contributor

Perhaps we should have arch-labels on the PRs which would then require a test report from such an arch to be able to merge?

@boegel
Copy link
Member Author

boegel commented Nov 5, 2020

@verdurin Yes, we should have a test report from an Arm64 box here, I'll work on that.

@akesandgren Yeah, we should get a bit more organized there...

@terjekv
Copy link
Collaborator

terjekv commented Nov 12, 2020

Test report by @terjekv
SUCCESS
Build succeeded for 46 out of 46 (2 easyconfigs in total)
arm2 - Linux ubuntu 18.04, AArch64, UNKNOWN, Python 3.6.9
See https://gist.github.com/234c896e70529cdeb52aba909fead8ea for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 14, 2020

@verdurin Test report from an Arm64 system done, see @terjekv's test report, so good to go?

Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Member

Going in, thanks @boegel!

@verdurin verdurin merged commit 7be3f9f into easybuilders:develop Nov 15, 2020
@boegel boegel deleted the 20201104155759_new_pr_TensorFlow231 branch November 16, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix EESSI Related to EESSI project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants