Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alternative checksum for codetools 0.2-16 in R 3.6.x easyconfigs #11736

Merged
merged 1 commit into from Nov 18, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 18, 2020

(created using eb --new-pr)
cfr. #11616

@boegel boegel added the bug fix label Nov 18, 2020
@boegel boegel added this to the 4.3.2 milestone Nov 18, 2020
@boegel
Copy link
Member Author

boegel commented Nov 18, 2020

@smoors Uploading test reports for all of these would be really painful, and not worth the effort imho.

The diff shown in #11616 confirms that there are no actual code changes in the codetools sources, so this should be good to go.

I'll ask my bot to just re-test a couple of these easyconfigs with --skip and --force-download, that should be sufficient...

@boegel
Copy link
Member Author

boegel commented Nov 18, 2020

@boegelbot please test @ generoso
EB_ARGS=" R-3.6.0-foss-2019a.eb R-3.6.2-intel-2019b.eb R-3.6.3-foss-2020a.eb --force-download --sourcepath /tmp/$USER/pr11736 --skip --rebuild"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11736 EB_ARGS=" R-3.6.0-foss-2019a.eb R-3.6.2-intel-2019b.eb R-3.6.3-foss-2020a.eb --force-download --sourcepath /tmp/$USER/pr11736 --skip --rebuild" /apps/slurm/default/bin/sbatch --job-name test_PR_11736 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9786

Test results coming soon (I hope)...

- notification for comment with ID 729553972 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/b2cbc89c5ea0ee4a2dbb36ee7405d6a8 for a full test report.

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors merged commit 52e7bf6 into easybuilders:develop Nov 18, 2020
@boegel boegel deleted the 20201118085221_new_pr_R360 branch November 26, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants