Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch for JasPer 2.0.14 and 2.0.16 to fix missing -lm #11746

Closed

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 21, 2020

(created using eb --new-pr)

For some reason -lm is sometimes missing, while other times it's there.
Explicitly specifying in CMakeLists.txt that libm is required when linking fixes problems like:

./libjasper/libjasper.so.4.0.0: error: undefined reference to 'pow'

(see also https://bugs.gentoo.org/601070)

@boegel boegel added bug fix EESSI Related to EESSI project labels Nov 21, 2020
@boegel boegel added this to the 4.3.2 (next release) milestone Nov 21, 2020
@boegel
Copy link
Member Author

boegel commented Nov 21, 2020

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
node2632.swalot.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/dffae084702ab7f0d938f36459140a86 for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 21, 2020

@boegelbot please test @ generoso
EB_ARGS="JasPer-2.0.14-GCCcore-10.2.0.eb JasPer-2.0.14-GCCcore-7.3.0.eb JasPer-2.0.14-GCCcore-8.2.0.eb JasPer-2.0.14-GCCcore-8.3.0.eb JasPer-2.0.14-GCCcore-9.3.0.eb JasPer-2.0.16-GCCcore-9.3.0.eb"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11746 EB_ARGS="JasPer-2.0.14-GCCcore-10.2.0.eb JasPer-2.0.14-GCCcore-7.3.0.eb JasPer-2.0.14-GCCcore-8.2.0.eb JasPer-2.0.14-GCCcore-8.3.0.eb JasPer-2.0.14-GCCcore-9.3.0.eb JasPer-2.0.16-GCCcore-9.3.0.eb" /apps/slurm/default/bin/sbatch --job-name test_PR_11746 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9793

Test results coming soon (I hope)...

- notification for comment with ID 731592511 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/436805c6fca458ec197c259ac67f319b for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 21, 2020

The underlying cause here seems to be that libm.so is parked in <sysroot>/usr/lib64, and CMake isn't taking into that path when find_library is used... 🤦

@boegel
Copy link
Member Author

boegel commented Nov 21, 2020

Proper fix in CMakeMake easyblock via easybuilders/easybuild-easyblocks#2247, so closing this...

@boegel boegel closed this Nov 21, 2020
@boegel boegel deleted the 20201121154659_new_pr_JasPer2014 branch November 21, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix EESSI Related to EESSI project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants