Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{devel}[GCCcore/10.2.0] Bazel v3.7.1 #11810

Closed

Conversation

Micket
Copy link
Contributor

@Micket Micket commented Dec 3, 2020

(created using eb --new-pr)

@Micket Micket added the update label Dec 3, 2020
@Micket
Copy link
Contributor Author

Micket commented Dec 3, 2020

Test report by @Micket
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
vera-c1 - Linux centos linux 7.8.2003, x86_64, Intel Xeon Processor (Skylake), Python 2.7.5
See https://gist.github.com/af9032fe190890bbf8a49e576df8ba29 for a full test report.

@Micket
Copy link
Contributor Author

Micket commented Dec 3, 2020

/local/EB/build/eb-5ELu_U/bazel_x5LRfhQ7/out/execroot/io_bazel/bazel-out/host/bin/external/com_google_protobuf/protoc: /lib64/libstdc++.so.6: version `CXXABI_1.3.8' not found (required by /local/EB/build/eb-5ELu_U/bazel_x5LRfhQ7/out/execroot/io_bazel/bazel-out/host/bin/external/com_google_protobuf/protoc

Well crap, usual nonsense issues here that i was hoping to skip for once.

@Micket Micket marked this pull request as draft December 3, 2020 02:10
@Flamefire
Copy link
Contributor

I got a patch for that:

diff --git a/third_party/protobuf/3.13.0.patch b/third_party/protobuf/3.13.0.patch
index bde8684b82..3336ef4024 100644
--- a/third_party/protobuf/3.13.0.patch
+++ b/third_party/protobuf/3.13.0.patch
@@ -38,3 +38,15 @@ index cfdb28e2e..3705fdbe3 100644
 +        "@io_bazel//third_party:gson",
      ],
  )
+diff --git a/protobuf.bzl b/protobuf.bzl
+index 050eafc54..12d3edb94 100644
+--- a/protobuf.bzl
++++ b/protobuf.bzl
+@@ -352,6 +352,7 @@ def _internal_gen_well_known_protos_java_impl(ctx):
+         inputs = descriptors,
+         outputs = [srcjar],
+         arguments = [args],
++        use_default_shell_env = True,
+     )
+ 
+     return [

This also needs the static linking of process-wrapper

@boegel boegel added this to the 4.x milestone Dec 28, 2020
@boegel
Copy link
Member

boegel commented Jan 20, 2021

@Micket Please let us know if you're up for looking into applying that patch to fix the issue, or if someone should take over from you.

@Micket
Copy link
Contributor Author

Micket commented Jan 20, 2021

I haven't had time to think about this. Please feel free to steal this work from me :)

@Flamefire
Copy link
Contributor

Also requires easybuilders/easybuild-easyblocks#2285 (mentioned above, just adding the link for reference)

@branfosj
Copy link
Member

@Micket We've merged #12148 which includes Bazel-3.7.2-GCCcore-10.2.0.eb so I've closed this PR.

@branfosj branfosj closed this Feb 16, 2021
@Flamefire
Copy link
Contributor

Ah, sorry forgot about this PR

@Micket Micket deleted the 20201203025010_new_pr_Bazel371 branch April 21, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants