Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{numlib}[GCC/9.3.0] AMD-LibM v3.6.0-4, AMD-RNG v2.2, AMD-SecureRNG v2.2 #11929

Conversation

SebastianAchilles
Copy link
Member

(created using eb --new-pr)

@SebastianAchilles
Copy link
Member Author

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
ebvm.novalocal - Linux centos linux 8.3.2011, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/7752437264d2ca2b1e5e5f1d8a62faed for a full test report.

@migueldiascosta
Copy link
Member

@boegelbot please test @ generoso

@migueldiascosta
Copy link
Member

Test report by @migueldiascosta
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/bf9870c7c64dfee7a9eb99f6b8fa88e7 for a full test report.

@boegelbot
Copy link
Collaborator

@migueldiascosta: Request for testing this PR well received on generoso

PR test command 'EB_PR=11929 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11929 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12339

Test results coming soon (I hope)...

- notification for comment with ID 750629714 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/f453ad368038acf0be88ccc887beb0f6 for a full test report.

Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @SebastianAchilles!

@migueldiascosta migueldiascosta merged commit 0e22a51 into easybuilders:develop Dec 24, 2020
toolchain = {'name': 'GCC', 'version': '9.3.0'}

source_urls = ['http://developer.amd.com/wordpress/media/files/']
sources = ['aocl-rng-linux-gcc-%(version)s-4.tar.gz']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastianAchilles Shouldn't the -4 be part of the version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in #11934

toolchain = {'name': 'GCC', 'version': '9.3.0'}

source_urls = ['http://developer.amd.com/wordpress/media/files/']
sources = ['aocl-securerng-linux-gcc-%(version)s-4.tar.gz']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, shouldn't -4 be part of the version (like it is for AMD-LibM)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in #11935


sanity_check_paths = {
'files': [],
'dirs': ['lib'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a bit more specific, a sanity check like this isn't very useful imho :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in #11935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants