Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch to fix GCC 10.2.0 rejecting valid code on PPC #12948

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented May 25, 2021

(created using eb --new-pr)

Found during compilation of TF 2.5.0.
See https://gitlab.com/libeigen/eigen/-/issues/2259

Reproducer:

$ cat vecParam.cpp 
void ploadRhsMMA(__vector_pair&){}
int main(){
  __vector_pair p;
  ploadRhsMMA(p);
}

Compile as g++ vecParam.cpp.
Prior to this patch it will show: "error: invalid conversion from type '* __vector_pair'"

@branfosj branfosj added this to the 4.4.0 milestone May 25, 2021
@easybuilders easybuilders deleted a comment from boegelbot May 25, 2021
@Flamefire Flamefire force-pushed the 20210525124113_new_pr_GCCcore1020 branch from 9613ef9 to f4e8614 Compare May 25, 2021 11:41
@boegel
Copy link
Member

boegel commented May 25, 2021

@boegelbot please test @ generoso
CORE_CNT=16
EB_ARGS="--installpath /tmp/$USER"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12948 EB_ARGS="--installpath /tmp/$USER" /apps/slurm/default/bin/sbatch --job-name test_PR_12948 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17304

Test results coming soon (I hope)...

- notification for comment with ID 847842864 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
taurusml1 - Linux RHEL 7.6, POWER, 8335-GTX (power9le), Python 2.7.5
See https://gist.github.com/25810beabf40bfce7ae606e09ffc6c0a for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in total)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/45cb39b85885865b43f1b772577de81c for a full test report.

@boegel
Copy link
Member

boegel commented May 25, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
select-pika-c6gd-2xlarge-0001 - Linux centos linux 8.3.2011, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/a2ed4a5499b5560878c8f452036a07e1 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented May 25, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild2.novalocal - Linux centos linux 8.3.2011, POWER, IBM pSeries (emulated by qemu) (power9le), Python 3.6.8
See https://gist.github.com/b6f5074948e261c3c4e6a9fb3c36d87a for a full test report.

edit: even though this test report was uploaded with eb --module-only, it does represent a successful rebuild of GCCcore/10.2.0 on POWER9. And I've verified that the minimal test case indeed compiles properly now.

@boegel
Copy link
Member

boegel commented May 25, 2021

Going in, thanks @Flamefire!

@boegel boegel merged commit 8d80d3e into easybuilders:develop May 25, 2021
@Flamefire Flamefire deleted the 20210525124113_new_pr_GCCcore1020 branch May 25, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants