Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UCX patch to allow overriding modules #12980

Merged
merged 1 commit into from May 28, 2021
Merged

Add UCX patch to allow overriding modules #12980

merged 1 commit into from May 28, 2021

Conversation

Micket
Copy link
Contributor

@Micket Micket commented May 28, 2021

(created using eb --new-pr)

@Micket
Copy link
Contributor Author

Micket commented May 28, 2021

@akesandgren I found that UCS frequently uses it's own ucs_snprintf_safe so I opted to use that instead.

@Micket Micket added the 2021a label May 28, 2021
@Micket Micket added this to the 4.4.0 milestone May 28, 2021
@Micket Micket added this to In progress in 2021a common toolchains via automation May 28, 2021
@Micket
Copy link
Contributor Author

Micket commented May 28, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=12980 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12980 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17314

Test results coming soon (I hope)...

- notification for comment with ID 850368368 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/4db7074db98e12d8f1bd3cf11e7202d1 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
nuc.lan - Linux Fedora 33, x86_64, Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz, Python 3.9.4
See https://gist.github.com/b76eab31eb5f55d3736899aa03777cd3 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/3f30189ea7a5dd3b805fe0de3644554c for a full test report.

verdurin
verdurin approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

2021a common toolchains automation moved this from In progress to Reviewer approved May 28, 2021
@verdurin
Copy link
Member

Going in, thanks @Micket!

@verdurin verdurin merged commit e9561d8 into easybuilders:develop May 28, 2021
2021a common toolchains automation moved this from Reviewer approved to Done May 28, 2021
boegel
boegel reviewed May 28, 2021
View reviewed changes
easybuild/easyconfigs/u/UCX/UCX-1.10.0-dynamic_modules.patch
@@ -0,0 +1,27 @@
# UCX is hardcoded to only load the modules it is compiled with.
# This patch adds an optional EB_xxx_MODULES that can override this list, allowing new modules to be loaded later.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Micket Comment says EB_xxx, while it's actually EC_UCX_xxx, we should fix that to avoid confusion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in #12984

@Micket Micket deleted the 20210528120252_new_pr_UCX1100 branch April 21, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel left review comments

@verdurin verdurin verdurin approved these changes

Assignees
No one assigned
Labels
2021a enhancement
Projects
No open projects
2021a common toolchains
Done
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Micket @boegelbot @verdurin @boegel @migueldiascosta