Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[foss/2021a] pangolin v3.1.10 w/ Python 3.9.5 #13681

Conversation

SethosII
Copy link
Contributor

@SethosII SethosII commented Aug 10, 2021

(created using eb --new-pr)

This is an attempt to biuld pangolin from source. Some of the dependencies are not yet merged or still need to be created. See the discussion here: #13119. One blocker is that that there is currently no tbb version for foss/2021a which is needed for the dependency usher, see #13404.

Also: @sassy-crick

@SethosII SethosII changed the title {bio}[foss/2018b] pangolin v3.1.10 w/ Python 3.9.5 {bio}[foss/2021a] pangolin v3.1.10 w/ Python 3.9.5 Aug 10, 2021
@Micket Micket added the new label Aug 10, 2021
@@ -0,0 +1,65 @@
easyblock = 'PythonBundle'

name = 'pangolin'
Copy link
Contributor

@Micket Micket Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = 'pangolin'
name = 'Pangolin'

In my opinion

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At their GitHub it is actually all in lower cases which I would take as a guide here.
However at their webpage it is capitalized. I could ask my colleague if there is a preference in the community or maybe @SethosII has an opinion here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also use the lowercase version. They use the uppercase name only in some places, but the majority has the lowercase version including their setup.py and environment.yml.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created PR 13733 for the new version of pangolin

Co-authored-by: Mikael Öhman <micketeer@gmail.com>
@SethosII
Copy link
Contributor Author

Not relevant anymore.

@SethosII SethosII closed this Jul 15, 2022
@SethosII SethosII deleted the 20210810150949_new_pr_pangolin3110 branch July 15, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants