Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[gompi/2020b] IQ-TREE v2.1.2 #13991

Merged

Conversation

sassy-crick
Copy link
Collaborator

(created using eb --new-pr)

@verdurin
Copy link
Member

@sassy-crick Eigen/3.3.9 is only currently available in GCCcore/11.2.0 and 10.3.0. Please add the correct dependency.

@sassy-crick
Copy link
Collaborator Author

@sassy-crick Eigen/3.3.9 is only currently available in GCCcore/11.2.0 and 10.3.0. Please add the correct dependency.

I agree, However, the build fails with this version of Eigen with:
error: eigen_assert_exception is not a member of Eigen
Which got solved by the later version of Eigen. How shall we solve that?

@boegel
Copy link
Member

boegel commented Sep 16, 2021

@sassy-crick Since Eigen is just a build dependency, you can resolve the issue by adding an easyconfig for Eigen 3.3.9 with GCCcore/10.2.0 (maybe best in a separate PR).

This shouldn't cause trouble, because Eigen is a header-only library, so it's a build-only dependency (won't result in having two Eigen versions loaded at runtime).

@sassy-crick
Copy link
Collaborator Author

sassy-crick commented Sep 16, 2021

@boegel Thanks for your advice, I have done that as requested.

@easybuilders easybuilders deleted a comment from boegelbot Sep 17, 2021
@boegel boegel added the update label Sep 17, 2021
@boegel boegel added this to the next release (4.5.0?) milestone Sep 17, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title {bio}[foss/2020b] IQ-TREE bumped to 2.1.2, required for artic {bio}[foss/2020b] IQ-TREE v2.1.2 Sep 17, 2021
@verdurin
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=13991 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_13991 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6916

Test results coming soon (I hope)...

- notification for comment with ID 921881809 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
nuc.lan - Linux Fedora 33, x86_64, Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz, Python 3.9.6
See https://gist.github.com/ec4ffa88aec172db10090300fb865646 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/5642062eb06b241af40e3795ce83e01d for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/dfab95810682f4a30f563177a665ac85 for a full test report.

stick to gompi/2020b toolchain for IQ-TREE 2.1.2
@boegel boegel changed the title {bio}[foss/2020b] IQ-TREE v2.1.2 {bio}[gompi/2020b] IQ-TREE v2.1.2 Sep 17, 2021
@boegel
Copy link
Member

boegel commented Sep 17, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
node2635.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/2e469d6a8f893c2019f1aa020a2c50fb for a full test report.

@boegel
Copy link
Member

boegel commented Sep 17, 2021

Going in, thanks @sassy-crick!

@boegel boegel merged commit 9e9bdcd into easybuilders:develop Sep 17, 2021
@sassy-crick sassy-crick deleted the 20210915123124_new_pr_IQ-TREE212 branch September 17, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants