Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[system/system] TRUST4 v1.0.5.1 #14035

Conversation

scicomp-moffitt
Copy link
Contributor

(created using eb --new-pr)

@SebastianAchilles SebastianAchilles added this to the 4.x milestone Sep 19, 2021
Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the style check.

easybuild/easyconfigs/t/TRUST4/TRUST4-1.0.5.1.eb Outdated Show resolved Hide resolved
easybuild/easyconfigs/t/TRUST4/TRUST4-1.0.5.1.eb Outdated Show resolved Hide resolved
easybuild/easyconfigs/t/TRUST4/TRUST4-1.0.5.1.eb Outdated Show resolved Hide resolved
@boegelbot
Copy link
Collaborator

@scicomp-moffitt: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/1250199705
Output from first failing test suite run:

FAIL: test_style_conformance (test.easyconfigs.styletests.StyleTest)
Check the easyconfigs for style
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/styletests.py", line 57, in test_style_conformance
    self.assertEqual(result, 0, "Found code style errors (and/or warnings): %s" % result)
AssertionError: Found code style errors (and/or warnings): 2

----------------------------------------------------------------------
Ran 13341 tests in 685.011s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

scicomp-moffitt and others added 3 commits September 19, 2021 12:46
Co-authored-by: SebastianAchilles <achilles@aices.rwth-aachen.de>
Co-authored-by: SebastianAchilles <achilles@aices.rwth-aachen.de>
Co-authored-by: SebastianAchilles <achilles@aices.rwth-aachen.de>
@SebastianAchilles
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=14035 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14035 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6933

Test results coming soon (I hope)...

- notification for comment with ID 922739349 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/37f0ef01e9ba8ad64a7c5d00efbc96ed for a full test report.

Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Member

Going in, thanks @scicomp-moffitt!

@SebastianAchilles SebastianAchilles merged commit 7c62fc8 into easybuilders:develop Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants