Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exception to easyconfigs test suite for (indirect) TensorFlow 2.2.3 dependency for artic-ncov2019 #14037

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

sassy-crick
Copy link
Collaborator

Added artic-ncov2019-2021.06.24 for TF version 2.2.3 as artic-ncov2019-2021.06.24 required medaka which itself required TF-2.2.3.

Added artic-ncov2019-2021.06.24 for TF version 2.2.3 as artic-ncov2019-2021.06.24 required medaka which itself required TF-2.2.3.
Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should correct the name for the exception.

test/easyconfigs/easyconfigs.py Outdated Show resolved Hide resolved
Co-authored-by: SebastianAchilles <achilles@aices.rwth-aachen.de>
@SebastianAchilles SebastianAchilles added this to the 4.x milestone Sep 20, 2021
@SebastianAchilles
Copy link
Member

This exception is required for #13852

Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Member

Going in, thanks @sassy-crick!

@SebastianAchilles SebastianAchilles merged commit b975cde into easybuilders:develop Sep 20, 2021
@boegel boegel changed the title Update to include artic-ncov2019-2021.06.24 add exception to easyconfigs test suite for (indirect) TensorFlow 2.2.3 dependency for artic-ncov2019 Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants