Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{tools}[GCC/10.3.0] radeontop v1.3 #14124

Merged

Conversation

nordmoen
Copy link
Contributor

(created using eb --new-pr)

@lexming
Copy link
Contributor

lexming commented Oct 12, 2021

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node300.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/8a1c419cd0e15d3ba9e485c7f3020cfe for a full test report.

Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nordmoen Thanks for your contribution. It works well, I just changed the toolchain to GCCcore be able to merge it. The reason is that radeontop is a utility program and as such, it is more important that it is easily available in all toolchains than being able to build it with different compilers (GCC vs intel-compilers).

Apart from the change of toolchain, I made the following minor changes:

  • use github_account to define the location of the source files
  • clarify that sanity checks for radeontop would needs special permissions

Let me know if you agree with these changes.

LGTM

@lexming
Copy link
Contributor

lexming commented Oct 12, 2021

@boegelbot: please test @ generoso

@lexming lexming added the new label Oct 12, 2021
@lexming lexming added this to the next release (4.5.0?) milestone Oct 12, 2021
@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=14124 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14124 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7063

Test results coming soon (I hope)...

- notification for comment with ID 941102147 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/71ac3a922693a5694f448371c8631c30 for a full test report.

@nordmoen
Copy link
Contributor Author

nordmoen commented Oct 13, 2021

Let me know if you agree with these changes.

Looks great! Didn't know about the github_account option, looks very clean.

@lexming
Copy link
Contributor

lexming commented Oct 13, 2021

Going in, thanks @nordmoen !

@lexming lexming merged commit 5e2774e into easybuilders:develop Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants