New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{tools}[GCC/10.3.0] radeontop v1.3 #14124
{tools}[GCC/10.3.0] radeontop v1.3 #14124
Conversation
Test report by @lexming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nordmoen Thanks for your contribution. It works well, I just changed the toolchain to GCCcore
be able to merge it. The reason is that radeontop
is a utility program and as such, it is more important that it is easily available in all toolchains than being able to build it with different compilers (GCC vs intel-compilers).
Apart from the change of toolchain, I made the following minor changes:
- use
github_account
to define the location of the source files - clarify that sanity checks for radeontop would needs special permissions
Let me know if you agree with these changes.
LGTM
@boegelbot: please test @ generoso |
@lexming: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 941102147 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Looks great! Didn't know about the |
Going in, thanks @nordmoen ! |
(created using
eb --new-pr
)