Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{tools}[GCCcore/10.3.0] ROCm v4.3.1 w/ Python 3.9.5 #14156

Closed

Conversation

nordmoen
Copy link
Contributor

(created using eb --new-pr)

@nordmoen nordmoen marked this pull request as draft October 15, 2021 06:14
@boegelbot
Copy link
Collaborator

@nordmoen: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/1344816148
Last 100 lines of output from first failing test suite run:

Make sure a custom sanity_check_paths value is specified for easyconfigs that use a generic easyblock.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 1016, in test_pr_sanity_check_paths
    for ec in self.changed_ecs:
  File "test/easyconfigs/easyconfigs.py", line 272, in changed_ecs
    self._get_changed_easyconfigs()
  File "test/easyconfigs/easyconfigs.py", line 224, in _get_changed_easyconfigs
    for ec in self.parsed_easyconfigs:
  File "test/easyconfigs/easyconfigs.py", line 247, in parsed_easyconfigs
    EasyConfigTest.parse_all_easyconfigs()
  File "test/easyconfigs/easyconfigs.py", line 192, in parse_all_easyconfigs
    cls._parsed_easyconfigs.extend(process_easyconfig(spec))
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 2046, in process_easyconfig
    raise EasyBuildError("Failed to process easyconfig %s: %s", spec, err.msg)
EasyBuildError: 'Failed to process easyconfig /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/ROCm/ROCm-4.3.1-GCCcore-10.3.0-amd.eb: Failed to obtain class for EB_ROCM easyblock (not available?): No module named rocm'

======================================================================
ERROR: test_pr_sha256_checksums (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure changed easyconfigs have SHA256 checksums in place.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 850, in test_pr_sha256_checksums
    for ec in self.changed_ecs:
  File "test/easyconfigs/easyconfigs.py", line 272, in changed_ecs
    self._get_changed_easyconfigs()
  File "test/easyconfigs/easyconfigs.py", line 224, in _get_changed_easyconfigs
    for ec in self.parsed_easyconfigs:
  File "test/easyconfigs/easyconfigs.py", line 247, in parsed_easyconfigs
    EasyConfigTest.parse_all_easyconfigs()
  File "test/easyconfigs/easyconfigs.py", line 192, in parse_all_easyconfigs
    cls._parsed_easyconfigs.extend(process_easyconfig(spec))
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 2046, in process_easyconfig
    raise EasyBuildError("Failed to process easyconfig %s: %s", spec, err.msg)
EasyBuildError: 'Failed to process easyconfig /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/ROCm/ROCm-4.3.1-GCCcore-10.3.0-amd.eb: Failed to obtain class for EB_ROCM easyblock (not available?): No module named rocm'

======================================================================
ERROR: test_r_libs_site_env_var (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure $R_LIBS_SITE is being updated, rather than $R_LIBS.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 804, in test_r_libs_site_env_var
    for ec in self.parsed_easyconfigs:
  File "test/easyconfigs/easyconfigs.py", line 247, in parsed_easyconfigs
    EasyConfigTest.parse_all_easyconfigs()
  File "test/easyconfigs/easyconfigs.py", line 192, in parse_all_easyconfigs
    cls._parsed_easyconfigs.extend(process_easyconfig(spec))
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 2046, in process_easyconfig
    raise EasyBuildError("Failed to process easyconfig %s: %s", spec, err.msg)
EasyBuildError: 'Failed to process easyconfig /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/ROCm/ROCm-4.3.1-GCCcore-10.3.0-amd.eb: Failed to obtain class for EB_ROCM easyblock (not available?): No module named rocm'

======================================================================
ERROR: test_sanity_check_paths (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure specified sanity check paths adher to the requirements.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 788, in test_sanity_check_paths
    for ec in self.parsed_easyconfigs:
  File "test/easyconfigs/easyconfigs.py", line 247, in parsed_easyconfigs
    EasyConfigTest.parse_all_easyconfigs()
  File "test/easyconfigs/easyconfigs.py", line 192, in parse_all_easyconfigs
    cls._parsed_easyconfigs.extend(process_easyconfig(spec))
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 2046, in process_easyconfig
    raise EasyBuildError("Failed to process easyconfig %s: %s", spec, err.msg)
EasyBuildError: 'Failed to process easyconfig /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/ROCm/ROCm-4.3.1-GCCcore-10.3.0-amd.eb: Failed to obtain class for EB_ROCM easyblock (not available?): No module named rocm'

----------------------------------------------------------------------
Ran 13465 tests in 513.376s

FAILED (errors=9)
Found 13452 easyconfigs...
(skipped conflicts test)
(skipped dep graph test)
Merge base for develop and HEAD: 0a5948d8491ffdfee5421e91c4208c42d6693fa4
Merge base for develop and HEAD: 0a5948d8491ffdfee5421e91c4208c42d6693fa4

List of added easyconfig files in this PR:
	ROCm-4.3.1-GCCcore-10.3.0-amd.eb
Merge base for develop and HEAD: 0a5948d8491ffdfee5421e91c4208c42d6693fa4
Merge base for develop and HEAD: 0a5948d8491ffdfee5421e91c4208c42d6693fa4

List of added easyconfig files in this PR:
	ROCm-4.3.1-GCCcore-10.3.0-amd.eb
Merge base for develop and HEAD: 0a5948d8491ffdfee5421e91c4208c42d6693fa4
Merge base for develop and HEAD: 0a5948d8491ffdfee5421e91c4208c42d6693fa4

List of added easyconfig files in this PR:
	ROCm-4.3.1-GCCcore-10.3.0-amd.eb
Merge base for develop and HEAD: 0a5948d8491ffdfee5421e91c4208c42d6693fa4
Merge base for develop and HEAD: 0a5948d8491ffdfee5421e91c4208c42d6693fa4

List of added easyconfig files in this PR:
	ROCm-4.3.1-GCCcore-10.3.0-amd.eb
Merge base for develop and HEAD: 0a5948d8491ffdfee5421e91c4208c42d6693fa4
Merge base for develop and HEAD: 0a5948d8491ffdfee5421e91c4208c42d6693fa4

List of added easyconfig files in this PR:
	ROCm-4.3.1-GCCcore-10.3.0-amd.eb
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@Micket Micket added the new label Oct 28, 2021

name = 'ROCm'
version = '4.3.1'
versionsuffix = '-amd'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the suffix is not necessary; this is always AMD?


# Same build order as AOMP
# https://github.com/ROCm-Developer-Tools/aomp/blob/aomp-dev/bin/build_aomp.sh#L98
components = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure a mega bundle is the way forward. It's going to be very very painful to build test and maintain like that. I would suggest splitting these out as separate packages and perhaps have ROCm depend on them. This would allow partial progress (in both building, and developing the packages). I tried packaging some of these for Julia a while back, and I'm certain at least some of these can just be built standalone and work just like any library.

@nordmoen
Copy link
Contributor Author

Closing in favor of #14327

@nordmoen nordmoen closed this Nov 12, 2021
@boegel boegel added this to the 4.x milestone Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants