Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[foss/2021b] pangolin v3.1.16 w/ Python 3.9.6 + pangoLEARN v2021-10-18 and v2021-11-25 #14310

Merged

Conversation

sassy-crick
Copy link
Collaborator

(created using eb --new-pr)

…angoLEARN as extension to discriminate different versions
@sassy-crick
Copy link
Collaborator Author

In light of the recently found omikron-variant of Sars-CoV-2, pangoLEARN and pango-designation have been updated. In order to keep the current version for comparison, I suggest to use the version prefix of pangoLEARN as a unique handle. This way, if and when new variant will come along, a quick update can be undertaken without doing in-place replacing.

@migueldiascosta
Copy link
Member

In light of the recently found omikron-variant of Sars-CoV-2, pangoLEARN and pango-designation have been updated. In order to keep the current version for comparison, I suggest to use the version prefix of pangoLEARN as a unique handle. This way, if and when new variant will come along, a quick update can be undertaken without doing in-place replacing.

assuming the version of pangoLEARN is only relevant at runtime, couldn't it be a separate module, swapable after pangolin is loaded?

@easybuilders easybuilders deleted a comment from boegelbot Dec 3, 2021
@easybuilders easybuilders deleted a comment from boegelbot Dec 3, 2021
@boegel
Copy link
Member

boegel commented Dec 3, 2021

In light of the recently found omikron-variant of Sars-CoV-2, pangoLEARN and pango-designation have been updated. In order to keep the current version for comparison, I suggest to use the version prefix of pangoLEARN as a unique handle. This way, if and when new variant will come along, a quick update can be undertaken without doing in-place replacing.

assuming the version of pangoLEARN is only relevant at runtime, couldn't it be a separate module, swapable after pangolin is loaded?

It could be, but this approach makes sense to me too, I think (we briefly discussed this in the EasyBuild Slack too).
In some sense, it's a statement that these particular versions of pangoLEARN and pangolin are compatible.
If there's only a pangoLEARN module, you're left wondering whether you can use that in combination with pangolin that was installed with an older pangoLEARN.

@boegel boegel changed the title {bio}[foss/2021b] pangolin v3.1.16 w/ Python 3.9.6 {bio}[foss/2021b] pangolin v3.1.16 w/ Python 3.9.6 + pangoLEARN 2021-10-18 Dec 3, 2021
@boegel boegel changed the title {bio}[foss/2021b] pangolin v3.1.16 w/ Python 3.9.6 + pangoLEARN 2021-10-18 {bio}[foss/2021b] pangolin v3.1.16 w/ Python 3.9.6 + pangoLEARN v2021-10-18 and v2021-11-25 Dec 3, 2021
@boegel
Copy link
Member

boegel commented Dec 3, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3147.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/d3d38306d9ba983d9a12aab6c691b873 for a full test report.

@boegel
Copy link
Member

boegel commented Dec 3, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3507.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/cfdd035ff22e6f84fad6dd5148c4bab4 for a full test report.

@boegel
Copy link
Member

boegel commented Dec 3, 2021

@boegelbot please test @ generoso

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14310 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14310 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7432

Test results coming soon (I hope)...

- notification for comment with ID 985711623 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/6186d87cb2557df5ba61f0511ce41e0d for a full test report.

@boegel
Copy link
Member

boegel commented Dec 3, 2021

Going in, thanks @sassy-crick!

@boegel boegel merged commit 4fcacc8 into easybuilders:develop Dec 3, 2021
@sassy-crick sassy-crick deleted the 20211108232530_new_pr_pangolin3116 branch December 4, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants