Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch to fix broken (hanging) Mash binaries #14511

Merged
merged 7 commits into from Dec 7, 2021

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Dec 7, 2021

Fixes #14509 by reintroducing (an updated version of) the patches that were already used for version 2.1. I've also added sanity check commands for all Mash easyconfigs, as this would have spotted the issue.

@bedroge
Copy link
Contributor Author

bedroge commented Dec 7, 2021

Just noticed that version 2.0 also needs a patch, it has the same issue (sanity check now hangs)...

@bedroge
Copy link
Contributor Author

bedroge commented Dec 7, 2021

Solved that by using the patches from version 2.1, which also work fine for 2.0.

@bedroge
Copy link
Contributor Author

bedroge commented Dec 7, 2021

Test report by @bedroge
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
pg-interactive.hpc.rug.nl - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 3.6.8
See https://gist.github.com/f14edd53333c2a76afe8897e7fb988b5 for a full test report.

@bedroge
Copy link
Contributor Author

bedroge commented Dec 7, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=14511 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14511 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7443

Test results coming soon (I hope)...

- notification for comment with ID 987790173 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@bedroge bedroge added this to the 4.x milestone Dec 7, 2021
@verdurin
Copy link
Member

verdurin commented Dec 7, 2021

Test report by @verdurin
SUCCESS
Build succeeded for 5 out of 5 (4 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/99629460fc8b2966be2967f8a3c149d4 for a full test report.

@verdurin
Copy link
Member

verdurin commented Dec 7, 2021

Test report by @verdurin
SUCCESS
Build succeeded for 6 out of 6 (4 easyconfigs in total)
centos7.lan - Linux centos linux 7.9.2009, x86_64, Intel Core Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/8304007ca9739439bc70d9f84d20b32d for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 4 out of 32 (4 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/09533c6cfd8e071fde02fc35319d7018 for a full test report.

@verdurin
Copy link
Member

verdurin commented Dec 7, 2021

@bedroge seems like generoso is too new to build GCCcore/6.4.0?

@bedroge
Copy link
Contributor Author

bedroge commented Dec 7, 2021

@bedroge seems like generoso is too new to build GCCcore/6.4.0?

Yes, looks like it:
#10950

@boegel
Copy link
Member

boegel commented Dec 7, 2021

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node2613.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/c5b0cfb35a38a1de9d06466d0acd3257 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Fix broken (hanging) Mash binaries add patch to fix broken (hanging) Mash binaries Dec 7, 2021
@boegel boegel modified the milestones: 4.x, next release (4.5.1?) Dec 7, 2021
@boegel
Copy link
Member

boegel commented Dec 7, 2021

Going in, thanks @bedroge!

@boegel boegel merged commit 11fb7b5 into easybuilders:develop Dec 7, 2021
@bedroge bedroge deleted the mash_fix_broken_binaries branch December 7, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mash binaries are broken
4 participants