Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore missing binutils dependency for binaries in easyconfigs test suite #14718

Conversation

zemu-unile
Copy link
Contributor

By default the testsuite checks for a binutils or GCC dependency, when
using the GCCcore toolchain to avoid accidentially using the system
binutils. However, this is not necessary for packages that do not need
to be build like binaries. This commit adds exceptions for the 'Binary'
and the 'PackedBinary' easyblock to the existing exception for the
'Tarball' easyblock.

By default the testsuite checks for a binutils or GCC dependency, when
using the GCCcore toolchain to avoid accidentially using the system
binutils. However, this is not necessary for packages that do not need
to be build like binaries. This commit adds exceptions for the 'Binary'
and the 'PackedBinary' easyblock to the existing exception for the
'Tarball' easyblock.
@zemu-unile zemu-unile changed the title ignore missing binutils dependency for binaries testsuite: ignore missing binutils dependency for binaries Jan 14, 2022
@boegel boegel added this to the 4.x milestone Feb 2, 2022
@boegel boegel changed the title testsuite: ignore missing binutils dependency for binaries ignore missing binutils dependency for binaries in easyconfigs test suite Feb 2, 2022
@boegel
Copy link
Member

boegel commented Feb 2, 2022

@zemu-unile There are probably cases where the Binary or PackedBinary easyblocks are used, but still some compilation is being done (and then we really do want binutils included as a build dependency), so I'm not sure this is a good idea to do in general (but I do understand that it can be annoying when the tests require including binutils when there's no compilation being done at all).

Do you have specific examples of PRs that made you look into this change?

@zemu-unile
Copy link
Contributor Author

#14714 is failing the test as it is just a Perl script.

@zemu-unile
Copy link
Contributor Author

already resolved in #15932

@zemu-unile zemu-unile closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants