Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lib}[GCCcore/10.3.0] tokenizers v0.12.1 w/ Python 3.9.5 #15587

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Jun 1, 2022

(created using eb --new-pr)
requires:

An older version of Rust doesn't work, because new language features are used (with Rust 1.52.1 I was hitting rust-lang/rust#81119)

@boegel
Copy link
Member Author

boegel commented Jun 1, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3162.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/3d3214ca98372c09df98613e4938b8f9 for a full test report.

@jfgrimm
Copy link
Member

jfgrimm commented Jun 1, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
himem06.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/61a59e663421ac6387ad72a84aae4d3e for a full test report.

@boegel
Copy link
Member Author

boegel commented Jun 3, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15587 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15587 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8635

Test results coming soon (I hope)...

- notification for comment with ID 1145809609 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/05cd640a2946ff909b0032b54f65be19 for a full test report.

@Micket
Copy link
Contributor

Micket commented Jun 5, 2022

A dry run revealed that we are now actually in a position to having to build 2 rusts in order to build this (we should really solve the cryptography issue in Python...)

 * [x] /apps/easybuild-easyconfigs/easybuild/easyconfigs/r/Rust/Rust-1.52.1-GCCcore-10.3.0.eb (module: Rust/1.52.1-GCCcore-10.3.0)
 * [ ] /apps/easybuild-easyconfigs/easybuild/easyconfigs/r/Rust/Rust-1.60.0-GCCcore-10.3.0.eb (module: Rust/1.60.0-GCCcore-10.3.0)

Do we care? Ann alternative would be to stick to using 1.52.1 Rust for GCC 10.3.0 era packages.

@boegel
Copy link
Member Author

boegel commented Jun 7, 2022

@Micket As mentioned in the PR description, Rust 1.52.1 is not recent enough for tokenenizers.

If we want to avoid two Rust versions, we would need to bump Rust 1.52.1 to 1.60.0 as a build dependency everywhere for the 2021a generation of easyconfigs. That seems more pain than it's worth, just because one specific package requires a more recent Rust...

@lexming
Copy link
Contributor

lexming commented Nov 21, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=15587 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_15587 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9607

Test results coming soon (I hope)...

- notification for comment with ID 1321968350 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/5ab2c72ffa71ee9474d8f007a429a27b for a full test report.

Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Nov 21, 2022

Going in, thanks @boegel !

@lexming lexming merged commit 005dd51 into easybuilders:develop Nov 21, 2022
@lexming lexming modified the milestones: 4.x, next release (4.6.3?) Nov 21, 2022
@boegel boegel deleted the 20220601205617_new_pr_tokenizers0121 branch November 21, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants