-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{lib}[GCCcore/10.3.0] tokenizers v0.12.1 w/ Python 3.9.5 #15587
{lib}[GCCcore/10.3.0] tokenizers v0.12.1 w/ Python 3.9.5 #15587
Conversation
Test report by @boegel |
Test report by @jfgrimm |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1145809609 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
A dry run revealed that we are now actually in a position to having to build 2 rusts in order to build this (we should really solve the cryptography issue in Python...)
Do we care? Ann alternative would be to stick to using 1.52.1 Rust for GCC 10.3.0 era packages. |
@Micket As mentioned in the PR description, Rust 1.52.1 is not recent enough for If we want to avoid two Rust versions, we would need to bump Rust 1.52.1 to 1.60.0 as a build dependency everywhere for the |
…asyconfigs into 20220601205617_new_pr_tokenizers0121
@boegelbot: please test @ generoso |
@lexming: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1321968350 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going in, thanks @boegel ! |
(created using
eb --new-pr
)requires:
An older version of Rust doesn't work, because new language features are used (with Rust 1.52.1 I was hitting rust-lang/rust#81119)