Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix libsanitzer for glibc 2.36 to build GCCcore 10.x and 11.x #16502

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Oct 28, 2022

(created using eb --new-pr)

In #16145 I did GCCcore-11.3.0.eb. We've had it confirmed that that fixes the issue and that there is the same issue in GCCcore-10.3.0.eb. So this PR adds the same patch to all GCCcore 10.x and 11.x easyconfigs.

The 10.x changes look larger as this also changes to the new format checksums.

For 11.x I have maintained the order of the patches with GCCcore-11.3.0.eb, which is why the new patch is not the last in the list.

@branfosj branfosj added this to the next release (4.6.3?) milestone Oct 28, 2022
@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/3f586a88b6b55c26eaa40b231848f4de for a full test report.

@smoors
Copy link
Contributor

smoors commented Oct 29, 2022

@boegelbot please test @ generoso CORE_CNT=16

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=16502 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16502 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9404

Test results coming soon (I hope)...

- notification for comment with ID 1295795705 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/bc8fc16ab794fb9fa3efa99d67162df2 for a full test report.

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Oct 29, 2022

Going in, thanks @branfosj!

@smoors smoors merged commit faeecc7 into easybuilders:develop Oct 29, 2022
@branfosj branfosj deleted the 20221028084502_new_pr_GCCcore1010 branch October 29, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants