Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{bio}[foss/2020b] svist4get v1.3.1 w/ Python 3.8.6 #16505

Merged
merged 5 commits into from Nov 1, 2022
Merged

{bio}[foss/2020b] svist4get v1.3.1 w/ Python 3.8.6 #16505

merged 5 commits into from Nov 1, 2022

Conversation

sassy-crick
Copy link
Collaborator

@sassy-crick sassy-crick commented Oct 28, 2022 •
edited

(created using eb --new-pr)

This was referenced Oct 28, 2022
Merged
Closed
@sassy-crick sassy-crick changed the title {bio}[foss/2020b] svist4get v1.3.1 w/ Python 3.8.6 {bio}[foss/2020b] svist4get v1.3.1 w/ Python 3.8.6 WIB Oct 28, 2022
@sassy-crick
Copy link
Collaborator Author

sassy-crick commented Oct 28, 2022 •
edited

It looks like it is picking up freetype from my build environment which I only spotted when I build inside my container. Adding ('freetype', '2.10.3'), did not fix that.It appears it does not pick up the EasyBuild environment variables and I am currently hunting for ideas. Any suggestions welcome.
Update: fixed, so WIP removed

sassy and others added 4 commits October 28, 2022 23:37
reportlab patched so it finds EB fontconfig instead system one
c5c6cdf
Patchfile added
af342d6
@sassy-crick
Update svist4get-1.3.1-foss-2020b.eb
160c1da 
Missing ImageMagick added (picked up OS installation before)
@sassy-crick
Update svist4get-1.3.1-foss-2020b.eb
ca066e8 
Pillow downgraded to 8.0.1, reportlab downgraded to 3.6.9 due to conflicts with TOBIAS
@sassy-crick sassy-crick changed the title {bio}[foss/2020b] svist4get v1.3.1 w/ Python 3.8.6 WIB {bio}[foss/2020b] svist4get v1.3.1 w/ Python 3.8.6 Oct 29, 2022
@easybuilders easybuilders deleted a comment from boegelbot Nov 1, 2022
@smoors smoors added the new label Nov 1, 2022
@smoors
Copy link
Contributor

smoors commented Nov 1, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=16505 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16505 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9415

Test results coming soon (I hope)...

- notification for comment with ID 1298663030 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/66ceaf88f3ad6f69117ab7cfa900c585 for a full test report.

@smoors smoors added this to the next release (4.6.3?) milestone Nov 1, 2022
smoors
smoors approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Nov 1, 2022

Going in, thanks @sassy-crick!

@smoors smoors merged commit 3f71bed into easybuilders:develop Nov 1, 2022
@sassy-crick sassy-crick deleted the 20221028183156_new_pr_svist4get131 branch November 1, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoors smoors smoors approved these changes

Assignees
No one assigned
Labels
new
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sassy-crick @smoors @boegelbot