-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{perf}[goolf-1.5.14] Score-P (REVIEW) #1661
Conversation
Automatic reply from Jenkins: Can I test this? |
Jenkins: ok to test |
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Test report by @geimer |
Test report by @boegel |
@geimer: from the log you sent me:
|
so, GLib depends on xmllint? |
No idea... Interestingly, I just tried to continue the GLib build manually with only the |
Wait... I have to load libffi, gettext, and Python too. The it fails in the same way. So yes, apparently it needs xmllint (or uses it if available). And since on my system it's picking up /usr/bin/xmllint - which doesn't work with libreadline.so found in |
@geimer: from https://developer.gnome.org/gio/stable/glib-compile-resources.html
|
So we need a (build?)dependency on libxml2, I guess. If so, this is probably true for many/all versions of GLib. I would therefore suggest to open a separate PR for this, merge that one first, and the come back to this PR. Does that make sense? |
@geimer: maybe we should try it here first, just to confirm it fixes the issue on your end? Making sure we have a PR to sync up all GLib easyconfigs make sense. |
That missing
to the libreadline easyconfig. |
@wpoely86: so, we should figure out whether this breaks anything on non-Debian systems... Can you open a WIP PR that makes that change in one of the libreadline easyconfigs, for testing purposes? |
Fail: https://gist.github.com/12044bcd400b5ea69e91 |
Test report by @geimer |
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
@geimer: please retry submitting a test report? |
Test report by @geimer |
Test report by @wpoely86 |
Test report by @boegel |
Going in, thanks for the effort on this @geimer, @wpoely86 for the reviewing & testing, and @jordiblasco for initiating this in #1026 |
{perf}[goolf-1.5.14] Score-P (REVIEW)
As discussed with @boegel, this PR provides an update of #1026. Still needs testing, though.