Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{perf}[goolf-1.5.14] Score-P (REVIEW) #1661

Merged
merged 24 commits into from
Jun 17, 2015
Merged

Conversation

geimer
Copy link
Contributor

@geimer geimer commented Jun 3, 2015

As discussed with @boegel, this PR provides an update of #1026. Still needs testing, though.

@hpcugentbot
Copy link
Contributor

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Member

boegel commented Jun 3, 2015

Jenkins: ok to test

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3301/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3301/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@geimer
Copy link
Contributor Author

geimer commented Jun 3, 2015

Test report by @geimer
FAILED
Build succeeded for 7 out of 11 (8 easyconfigs in this PR)
Linux debian 7.8, Intel(R) Xeon(R) CPU X5550 @ 2.67GHz, Python 2.7.3
See https://gist.github.com/fb65c647e64be54b3c7f for a full test report.

@boegel
Copy link
Member

boegel commented Jun 3, 2015

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/8911913d2da2403b113d for a full test report.

@boegel
Copy link
Member

boegel commented Jun 3, 2015

@geimer: from the log you sent me:

test.gresource.xml: Error on line 6 char 1: Error processing input file with xmllint:
/usr/bin/xmllint: symbol lookup error: /home/geimer/Projects/EasyBuild/_inst/software/MPI/GCC/4.8.2/OpenMPI/1.6.5/libreadline/6.2/lib/libreadline.so.6: undefined symbol: UP

@boegel
Copy link
Member

boegel commented Jun 3, 2015

so, GLib depends on xmllint?

@geimer
Copy link
Contributor Author

geimer commented Jun 3, 2015

No idea... Interestingly, I just tried to continue the GLib build manually with only the goolf toolchain module loaded. And it finished. Maybe a parallel build issue?

@geimer
Copy link
Contributor Author

geimer commented Jun 3, 2015

Wait... I have to load libffi, gettext, and Python too. The it fails in the same way. So yes, apparently it needs xmllint (or uses it if available). And since on my system it's picking up /usr/bin/xmllint - which doesn't work with libreadline.so found in LD_LIBRARY_PATH - it barfs...

@boegel
Copy link
Member

boegel commented Jun 3, 2015

@geimer: from https://developer.gnome.org/gio/stable/glib-compile-resources.html

XMLLINT
The full path to the xmllint executable. This is used to preprocess resources with the xml-stripblanks preprocessing option. If this environment variable is not set, xmllint is searched in the PATH.

@geimer
Copy link
Contributor Author

geimer commented Jun 3, 2015

So we need a (build?)dependency on libxml2, I guess. If so, this is probably true for many/all versions of GLib. I would therefore suggest to open a separate PR for this, merge that one first, and the come back to this PR. Does that make sense?

@boegel
Copy link
Member

boegel commented Jun 3, 2015

@geimer: maybe we should try it here first, just to confirm it fixes the issue on your end?

Making sure we have a PR to sync up all GLib easyconfigs make sense.

@boegel
Copy link
Member

boegel commented Jun 3, 2015

@geimer: geimer#2

@wpoely86
Copy link
Member

wpoely86 commented Jun 4, 2015

That missing UP symbol is pure a linkage problem. On Debian 7, I have fixed it by adding:

preconfigopts = " LDFLAGS='-ltinfo' "

to the libreadline easyconfig.

@boegel
Copy link
Member

boegel commented Jun 4, 2015

@wpoely86: so, we should figure out whether this breaks anything on non-Debian systems...

Can you open a WIP PR that makes that change in one of the libreadline easyconfigs, for testing purposes?

@wpoely86
Copy link
Member

wpoely86 commented Jun 4, 2015

@boegel here you go: #1670

@wpoely86
Copy link
Member

wpoely86 commented Jun 4, 2015

@boegel
Copy link
Member

boegel commented Jun 5, 2015

@geimer: #1666 is merged, which includes the fixes in geimer#2, so just sync your branch with develop?

@geimer
Copy link
Contributor Author

geimer commented Jun 8, 2015

Test report by @geimer
FAILED
Build succeeded for 7 out of 10 (8 easyconfigs in this PR)
Linux debian 7.8, Intel(R) Xeon(R) CPU X5550 @ 2.67GHz, Python 2.7.3
See https://gist.github.com/6f7bedec19de3d86e2ef for a full test report.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3455/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3455/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3456/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3456/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Jun 8, 2015

@geimer: please retry submitting a test report?

@geimer
Copy link
Contributor Author

geimer commented Jun 8, 2015

Test report by @geimer
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in this PR)
Linux debian 7.8, Intel(R) Xeon(R) CPU X5550 @ 2.67GHz, Python 2.7.3
See https://gist.github.com/1de82d9f67a9885df62a for a full test report.

@geimer geimer changed the title {perf}[goolf-1.5.14] Score-P (WIP) {perf}[goolf-1.5.14] Score-P (REVIEW) Jun 8, 2015
@wpoely86
Copy link
Member

wpoely86 commented Jun 8, 2015

Test report by @wpoely86
SUCCESS
Build succeeded for 23 out of 23 (8 easyconfigs in this PR)
Linux debian 7.8, Intel(R) Xeon(R) CPU 5130 @ 2.00GHz, Python 2.7.3
See https://gist.github.com/d57e1e88f0ce74045116 for a full test report.

@boegel
Copy link
Member

boegel commented Jun 17, 2015

Test report by @boegel
SUCCESS
Build succeeded for 17 out of 17 (8 easyconfigs in this PR)
Linux RHEL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/aab63229ea173e3cf94d for a full test report.

@boegel
Copy link
Member

boegel commented Jun 17, 2015

Going in, thanks for the effort on this @geimer, @wpoely86 for the reviewing & testing, and @jordiblasco for initiating this in #1026

boegel added a commit that referenced this pull request Jun 17, 2015
{perf}[goolf-1.5.14] Score-P (REVIEW)
@boegel boegel merged commit 325c1f3 into easybuilders:develop Jun 17, 2015
@boegel boegel mentioned this pull request Jun 17, 2015
@geimer geimer deleted the Score-P branch June 17, 2015 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants