Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lang}[foss/2022a] numba v0.56.4 w/ Python 3.10.4 + CUDA 11.7.0 #16814

Merged
merged 15 commits into from Jan 11, 2023

Conversation

surak
Copy link
Contributor

@surak surak commented Dec 7, 2022

(created using eb --new-pr)

…s: llvmlite-0.39_getparamattribute.patch, llvmlite-0.39_passmanager.patch, llvmlite-0.39_pass.patch, llvmlite-0.39_target.patch, llvmlite-0.39_targetregistry.patch, llvmlite-0.39_test-binding.patch
@surak
Copy link
Contributor Author

surak commented Dec 7, 2022

This is a follow-up on #16764

@Micket was not happy with the patches separately, but I prefer this way. In any case, all changes are more than welcome!

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
zen2-ubuntu-2210 - Linux Ubuntu 22.10 (Kinetic Kudu), x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.10.7
See https://gist.github.com/e15d389c12f28f539fc13fd74e256861 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bwd-rockylinux-91 - Linux Rocky Linux 9.1 (Blue Onyx), x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), 2 x NVIDIA NVIDIA GeForce GTX 1060 6GB, 515.86.01, Python 3.9.14
See https://gist.github.com/3e0f42f9a0fb81c59d122c612246ba78 for a full test report.

@Micket
Copy link
Contributor

Micket commented Dec 7, 2022

@Micket was not happy with the patches separately, but I prefer this way.

No comments in the patches, no references, no description of the patches and just named a single word that doesn't reflect what they do, and they aren't useful separately
compared to the pattern so far;
llvmlite-0.36.0_fix-LLVM-11.patch
llvmlite-0.37.0_fix-LLVM-12.patch
or, even better, just compared to using what looks to be what will be merged upstream; https://github.com/numba/llvmlite/pull/830.patch

I also note that llvmlite really asks for a special build of LLVM as well. numba/llvmlite#830 (comment)

which says:

The patches to LLVM 14 that are included with the recipe are pretty important. Numba uses SVML and that is not in LLVM mainline and needs to be patched in.

I don't think this is a new thing, and we've never done this custom LLVM before, so i'm not sure we care?

@boegel
Copy link
Member

boegel commented Jan 7, 2023

@surak Can you look into adding the missing descriptions and checksums for the patches?

I would also prefer a single patch rather than a bunch of small ones, I don't see the benefit of the latter.

@easybuilders easybuilders deleted a comment from boegelbot Jan 10, 2023
@easybuilders easybuilders deleted a comment from boegelbot Jan 11, 2023
@easybuilders easybuilders deleted a comment from boegelbot Jan 11, 2023
@boegel
Copy link
Member

boegel commented Jan 11, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16814 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16814 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9960

Test results coming soon (I hope)...

- notification for comment with ID 1379060423 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/10d5c45ebe64979520485b60f9b22fe3 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 11, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3154.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/9db95eaefc361d6323d3fc189b5776a9 for a full test report.

@boegel
Copy link
Member

boegel commented Jan 11, 2023

Going in, thanks @surak!

@boegel boegel merged commit 6b81f23 into easybuilders:develop Jan 11, 2023
@boegel boegel changed the title {lang}[foss/2022a] numba v0.56.4 w/ Python 3.10.4 {lang}[foss/2022a] numba v0.56.4 w/ Python 3.10.4 + CUDA 11.7.0 Jan 11, 2023
@boegel boegel modified the milestones: 4.x, next release (4.7.1?) Jan 11, 2023
@smoors
Copy link
Contributor

smoors commented Jan 11, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16814 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_16814 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2035

Test results coming soon (I hope)...

- notification for comment with ID 1379243459 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/e2b744ff217badf823332bd875a40672 for a full test report.

@surak surak deleted the 20221207173958_new_pr_numba0564 branch January 11, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants