Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further relax jax linalg_test test tolerance #17095

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

surak
Copy link
Contributor

@surak surak commented Jan 12, 2023

This test gives a slightly higher number while installing on Juwels booster.

@jfgrimm jfgrimm added this to the 4.x milestone Jan 13, 2023
@jfgrimm jfgrimm changed the title This is needed for JUWELS booster further relax Jax linalg_test test tolerance Jan 13, 2023
@boegel boegel modified the milestones: 4.x, next release (4.7.1?) Jan 18, 2023
@boegel
Copy link
Member

boegel commented Jan 18, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17095 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17095 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10029

Test results coming soon (I hope)...

- notification for comment with ID 1387280764 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Jan 18, 2023

Patch seems to need work, doesn't apply for jax-0.3.14-foss-2022a-CUDA-11.7.0.eb for example.

Full test report coming up...

@boegel boegel changed the title further relax Jax linalg_test test tolerance further relax jax linalg_test test tolerance Jan 18, 2023
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 5 (5 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/5728897a649816ccb1f8c7f55439089e for a full test report.

@branfosj
Copy link
Member

Patch seems to need work, doesn't apply for jax-0.3.14-foss-2022a-CUDA-11.7.0.eb for example.

Full test report coming up...

The new part of the patch only applies in the latest Jax easyconfigs. So, jax-0.3.9_relax-test-tolerance.patch should be reverted to the original content and a new patch added to relax the tolerance in the failing test for 0.3.23.

@boegel boegel added this to the release after 4.9.1 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants