Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in-place update of DB dependency to 18.1.40 in Perl 5.30.2 easyconfig (because sources for DB 18.1.32 are no longer available) #17319

Closed

Conversation

dithwick
Copy link
Contributor

@dithwick dithwick commented Feb 14, 2023

(created using eb --new-pr) Depends on #17318

@boegelbot
Copy link
Collaborator

@dithwick: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/4174417773
Output from first failing test suite run:

ERROR: test_conflicts (test.easyconfigs.easyconfigs.EasyConfigTest)
Check whether any conflicts occur in software dependency graphs.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 326, in test_conflicts
    self.assertFalse(check_conflicts(self.ordered_specs, modules_tool(), check_inter_ec_conflicts=False),
  File "test/easyconfigs/easyconfigs.py", line 278, in ordered_specs
    EasyConfigTest.resolve_all_dependencies()
  File "test/easyconfigs/easyconfigs.py", line 216, in resolve_all_dependencies
    cls._parsed_easyconfigs, modules_tool(), retain_all_deps=True)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/tools/robot.py", line 463, in resolve_dependencies
    raise_error_missing_deps(totally_missing, extra_msg="no easyconfig file or existing module found")
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/tools/robot.py", line 326, in raise_error_missing_deps
    raise EasyBuildError(error_msg)
EasyBuildError: 'Missing dependencies: DB/18.1.40-GCCcore-9.3.0 (no easyconfig file or existing module found)'

======================================================================
ERROR: test_dep_graph (test.easyconfigs.easyconfigs.EasyConfigTest)
Unit test that builds a full dependency graph.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 313, in test_dep_graph
    dep_graph(fn, self.ordered_specs)
  File "test/easyconfigs/easyconfigs.py", line 278, in ordered_specs
    EasyConfigTest.resolve_all_dependencies()
  File "test/easyconfigs/easyconfigs.py", line 216, in resolve_all_dependencies
    cls._parsed_easyconfigs, modules_tool(), retain_all_deps=True)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/tools/robot.py", line 463, in resolve_dependencies
    raise_error_missing_deps(totally_missing, extra_msg="no easyconfig file or existing module found")
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/tools/robot.py", line 326, in raise_error_missing_deps
    raise EasyBuildError(error_msg)
EasyBuildError: 'Missing dependencies: DB/18.1.40-GCCcore-9.3.0 (no easyconfig file or existing module found)'

======================================================================
ERROR: test_dep_versions_per_toolchain_generation (test.easyconfigs.easyconfigs.EasyConfigTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 853, in test_dep_versions_per_toolchain_generation
    for ec in self.ordered_specs:
  File "test/easyconfigs/easyconfigs.py", line 278, in ordered_specs
    EasyConfigTest.resolve_all_dependencies()
  File "test/easyconfigs/easyconfigs.py", line 216, in resolve_all_dependencies
    cls._parsed_easyconfigs, modules_tool(), retain_all_deps=True)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/tools/robot.py", line 463, in resolve_dependencies
    raise_error_missing_deps(totally_missing, extra_msg="no easyconfig file or existing module found")
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/tools/robot.py", line 326, in raise_error_missing_deps
    raise EasyBuildError(error_msg)
EasyBuildError: 'Missing dependencies: DB/18.1.40-GCCcore-9.3.0 (no easyconfig file or existing module found)'

----------------------------------------------------------------------
Ran 16403 tests in 930.800s

FAILED (errors=3)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@@ -21,7 +21,7 @@ dependencies = [
('expat', '2.2.9'), # for XML::Parser
('ncurses', '6.2'), # for Term::ReadLine::Gnu
('libreadline', '8.0'), # for Term::ReadLine::Gnu
('DB', '18.1.32'), # for DB_File
('DB', '18.1.40'), # for DB_File
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in-place updates like this are pretty painful...

Another solution to the source tarball for DB 18.1.32 no longer being available is to upload it at https://sources.easybuild.io, which is automatically considered as a fallback URL by EasyBuild.
That's only possible if the software license allows for redistribution though...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a copy of that source file myself. Maybe someone else does (as you say, depending on the license).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB 18.1.x is released under AGPL (+ UPL for examples) license, so sources can be redistributed -> see https://sources.easybuild.io/d/DB/

@dithwick With that, I think we can close this PR as well as #17318?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's fine with me of course

@boegel boegel changed the title Updated to reflect lack of availability of DB 18.1.32 source code. in-place update of DB dependency to 18.1.40 in Perl 5.30.2 easyconfig (because sources for DB 18.1.32 are no longer available) Feb 15, 2023
@boegel boegel added the change label Feb 15, 2023
@boegel boegel added this to the next release (4.7.1?) milestone Feb 15, 2023
@jfgrimm jfgrimm closed this Feb 17, 2023
@jfgrimm
Copy link
Member

jfgrimm commented Feb 17, 2023

closed as per: #17319 (comment)

@dithwick dithwick deleted the 20230214134406_new_pr_Perl5302 branch February 21, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants