Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistently use NanoFilt capitalisation #17349

Merged
merged 2 commits into from Feb 16, 2023
Merged

Conversation

branfosj
Copy link
Member

NanoFilt capitalisation looks right to me.

for #11824

@branfosj branfosj added this to the next release (4.7.1?) milestone Feb 15, 2023
@branfosj
Copy link
Member Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=17349 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17349 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10246

Test results coming soon (I hope)...

- notification for comment with ID 1431833172 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Feb 15, 2023

Do we care to test build these? toolchains are older than what i have in my test tree so i don't wanna

@branfosj
Copy link
Member Author

Do we care to test build these? toolchains are older than what i have in my test tree so i don't wanna

I've set a build off and will see how it goes. The starting point is "0 out of 72 easyconfigs done", so not as bad as I feared. However, we'll have to see if I can build all the dependencies in these older toolchains.

@verdurin verdurin changed the title consistently use NanoFilt capitailisation consistently use NanoFilt capitalisation Feb 16, 2023
@verdurin
Copy link
Member

Test report by @verdurin
FAILED
Build succeeded for 8 out of 16 (4 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/a6b58379e5bf80410d2d46afec1ddbaa for a full test report.

@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/471c61356c50b39b2e238faac1a6830d for a full test report.

@Micket
Copy link
Contributor

Micket commented Feb 16, 2023

Good enough for me!

@Micket Micket merged commit 85c2bec into easybuilders:develop Feb 16, 2023
@branfosj branfosj deleted the nanofilt branch February 16, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants