Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archive charmm and CHARMM easyconfigs to avoid case-insensitive name clash #17364

Merged
merged 1 commit into from Feb 17, 2023
Merged

archive charmm and CHARMM easyconfigs to avoid case-insensitive name clash #17364

merged 1 commit into from Feb 17, 2023

Conversation

branfosj
Copy link
Member

for #11824

charmm and CHARMM are different variants of the same software. However, all the easyconfigs are old. So, rather than sort out the naming now, we should archive them all and decide on the name if a new easyconfig is submitted.

@branfosj branfosj added this to the next release (4.7.1?) milestone Feb 17, 2023
Micket
Micket approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

For reference, i think we could just have "CHARMM" and label the free version with a versionsuffix (presumably, you can only ever use one of them at a time anyway, so they should conflict)

@Micket Micket merged commit 42e9973 into easybuilders:develop Feb 17, 2023
@branfosj branfosj deleted the charmm branch February 17, 2023 12:09
@boegel boegel added the change label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Micket Micket Micket approved these changes

Assignees
No one assigned
Labels
bug fix change
Projects
None yet
Milestone
4.7.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@branfosj @Micket @boegel