Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alternative checksum for MONAI 1.0.1 #17628

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Mar 30, 2023

(created using eb --new-pr)

$ diff -r MONAI-1.0.1.orig MONAI-1.0.1.new
diff -r MONAI-1.0.1.orig/monai/_version.py MONAI-1.0.1.new/monai/_version.py
26c26
<     git_refnames = " (tag: 1.0.1, main)"
---
>     git_refnames = " (tag: 1.0.1)"

@branfosj branfosj added this to the next release (4.7.2?) milestone Mar 30, 2023
@branfosj
Copy link
Member Author

@boegelbot please test @ generoso
EB_ARGS="--sourcepath /tmp/$USER/pr17628 --force-download --stop source"

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=17628 EB_ARGS="--sourcepath /tmp/$USER/pr17628 --force-download --stop source" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17628 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10566

Test results coming soon (I hope)...

- notification for comment with ID 1490757841 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/feeb59068156b7d53c25e5d012818dea for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Mar 31, 2023

Going in, thanks @branfosj!

@boegel boegel merged commit b599e0c into easybuilders:develop Mar 31, 2023
10 checks passed
@branfosj branfosj deleted the 20230330193711_new_pr_MONAI101 branch March 31, 2023 19:43
@boegel boegel changed the title Add alternative checksum for MONAI 1.0.1 add alternative checksum for MONAI 1.0.1 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants