-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{devel}[GCCcore/13.1.0] Perl v5.36.1 (with minimal set of extensions) + Autotools v20220317 #17806
{devel}[GCCcore/13.1.0] Perl v5.36.1 (with minimal set of extensions) + Autotools v20220317 #17806
Conversation
…71-GCCcore-13.1.0.eb, Automake-1.16.5-GCCcore-13.1.0.eb, libtool-2.4.7-GCCcore-13.1.0.eb, Perl-5.36.1-GCCcore-13.1.0.eb
Test report by @Micket |
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
@boegelbot please test @ jsc-zen2 |
@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1523329807 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ generoso |
@SebastianAchilles: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1523352487 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
homepage = 'https://www.perl.org/' | ||
description = """Larry Wall's Practical Extraction and Report Language | ||
|
||
This is a minimal build without any modules. Should only be used for build dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot about the description, if we go for this approach and skip the minimal variant altogether going forward, what should we write here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe drop the Should only be used for build dependencies.
, and just leave it at This is a minimal build without any modules.
Test report by @jfgrimm |
The minimal Perl as a build dep for |
I now compared with
and included all the extra perl modules they mention. Still pretty small, but not as minimal as before, so still possible to avoid cicular deps and needing to have 2 perls i think. |
This comment was marked as resolved.
This comment was marked as resolved.
Test report by @Micket |
Let's get #17884 tested & merged first, and then re-test here. |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1545908823 processed Message to humans: this is just bookkeeping information for me, |
|
||
# !! order of extensions is important !! | ||
# extensions updated on 2023-05-02 | ||
# includes all dependencies for Autotools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Micket We'll need to wait until we've discussed this new "minimal extensions" approach before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, though i strongly suspect this is the approach we have to go with more or less.
Test report by @boegel |
Test report by @boegelbot |
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
@boegelbot please test @ jsc-zen2 |
@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1554811209 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @Micket! |
(created using
eb --new-pr
)This intentionally changes perl to be the minimal version by default.
I don't know if it's a good idea if some of the extra packages are needed for the basic tools, like autotools. If so, might be worth including a few very basic extensions as long as it doesn't create cyclic dependency