[Julia-1.8.5] Prevent setting environment that breaks Julia #17995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julia breaks if the depot path is set to an unwritable location. At the same time, setting ~ into environment variables typically forces a creation of actual directory named `~`, creating mild risk of fun `rm -fr` stories and impacting data of novice usrers. Removing all environment fixes the problem and is generally safe (Julia will properly use a well-defaulted depot path).
|
Possibly fixes/duplicates also: |
lexming
reviewed
Jul 7, 2023
There was a problem hiding this comment.
This change breaks Julia packages distributed through EasyBuild like IJulia. Loading a Julia package through a module file on top of this easyconfig of Julia will disable the user's depot.
I agree with you in the dangers of using ~. I addressed that issue in the recent changes of #17976. I suggest to close this PR and maybe we can continue on that one, since that covers many more Julia easyconfigs.
|
@lexming Hi, thanks, I'm OK with closing this (actually let's do that right away). If I get it right, the |
|
@exaexa that's exactly it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia breaks if the depot path is set to an unwritable location. At the same time, setting ~ into environment variables typically forces a creation of actual directory named
~, creating mild risk of funrm -frstories and impacting data of novice usrers.Removing all environment fixes the problem and is generally safe (Julia will properly use a well-defaulted depot path).
cc @laurentheirendt @ekieffer (Thanks @ULHPC team for applying and quicktesting this fix).