Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove default separate_build_dir = True and CMAKE_BUILD_TYPE=Release from MariaDB #18223

Merged
merged 1 commit into from Jun 29, 2023
Merged

remove default separate_build_dir = True and CMAKE_BUILD_TYPE=Release from MariaDB #18223

merged 1 commit into from Jun 29, 2023

Conversation

branfosj
Copy link
Member

(created using eb --new-pr)

@branfosj branfosj added this to the next release (4.7.3?) milestone Jun 28, 2023
@branfosj branfosj changed the title remove default separate_build_dir = True and build_type = 'Release' from MariaDB remove default separate_build_dir = True and CMAKE_BUILD_TYPE=Release from MariaDB Jun 28, 2023
@branfosj
Copy link
Member Author

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18223 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18223 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2909

Test results coming soon (I hope)...

- notification for comment with ID 1611903040 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/bcd76c8d6778c7e3a17a979a4d0b3c87 for a full test report.

boegel
boegel approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jun 29, 2023

Going in, thanks @branfosj!

@boegel boegel merged commit 2ea9a98 into easybuilders:develop Jun 29, 2023
5 checks passed
@branfosj branfosj deleted the 20230628193825_new_pr_MariaDB10112 branch June 29, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
code cleanup
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@branfosj @boegelbot @boegel