Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use MCR dependency in FreeSurfer 7.3.2 and 7.4.0 #18303

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jul 13, 2023

(created using eb --new-pr)

See discussion in #18300 and the enhanced easyblock easybuilders/easybuild-easyblocks#2962 to catch the wrong MCR version issue.

@branfosj
Copy link
Member Author

Test report by @branfosj
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2962
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
bear-pg0105u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/2b77e5a9f10c0bee53c84eee5e43b037 for a full test report.

@migueldiascosta
Copy link
Member

@boegelbot please test @ generoso EB_ARGS="--include-easyblocks-from-pr 2962"

@boegelbot
Copy link
Collaborator

@migueldiascosta: Request for testing this PR well received on login1

PR test command 'EB_PR=18303 EB_ARGS="--include-easyblocks-from-pr 2962" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18303 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11242

Test results coming soon (I hope)...

- notification for comment with ID 1634923845 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2962
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/61d0d6d401b04d5856bb7fe971b2547e for a full test report.

@migueldiascosta
Copy link
Member

@boegelbot please test @ jsc-zen2 EB_ARGS="--include-easyblocks-from-pr 2962"

@boegelbot
Copy link
Collaborator

@migueldiascosta: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18303 EB_ARGS="--include-easyblocks-from-pr 2962" /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18303 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2981

Test results coming soon (I hope)...

- notification for comment with ID 1634979225 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2962
SUCCESS
Build succeeded for 6 out of 6 (5 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/076af192f89b1e5fb3a922f42f37f9ce for a full test report.

Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @branfosj!

@migueldiascosta migueldiascosta merged commit ac97208 into easybuilders:develop Jul 13, 2023
5 checks passed
@branfosj branfosj deleted the 20230713131912_new_pr_FreeSurfer732 branch July 14, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants