Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add build info message to easyconfig for NLTK 3.7 #18550

Merged
merged 2 commits into from Jan 31, 2024
Merged

add build info message to easyconfig for NLTK 3.7 #18550

merged 2 commits into from Jan 31, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Aug 12, 2023 •
edited

@branfosj branfosj mentioned this pull request Aug 12, 2023
Merged
@branfosj branfosj marked this pull request as draft August 12, 2023 09:46
@branfosj branfosj marked this pull request as ready for review January 15, 2024 10:56
@easybuilders easybuilders deleted a comment from boegelbot Jan 15, 2024
@branfosj branfosj added this to the 4.x milestone Jan 15, 2024
@boegel
Copy link
Member

boegel commented Jan 31, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=18550 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_18550 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12781

Test results coming soon (I hope)...

- notification for comment with ID 1918664448 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/88b9b05f7c294aa4fe50dca9fc052269 for a full test report.

@boegel boegel modified the milestones: 4.x, release after 4.9.0 Jan 31, 2024
boegel
boegel approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 31, 2024

Going in, thanks @branfosj!

@boegel boegel merged commit cb1f6a8 into easybuilders:develop Jan 31, 2024
9 checks passed
@branfosj branfosj deleted the build_info_msg_demo branch February 1, 2024 06:56
@boegel boegel changed the title demo of build_info_msg easyconfig parameter add build info message to easyconfig for NLTK 3.7 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.9.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@branfosj @boegel @boegelbot