New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[foss/2022a] EpiSCORE v0.9.5-20220621 w/ R 4.2.1 #18618
{bio}[foss/2022a] EpiSCORE v0.9.5-20220621 w/ R 4.2.1 #18618
Conversation
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1688159207 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegel |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen2 |
@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1688252060 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
easyblock = 'RPackage' | ||
|
||
name = 'EpiSCORE' | ||
local_commit = '4f7daef' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is guaranteed to be unique, better to use full commit string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use the short commit in every single easyconfig that uses local_commit, so i don't think we should start enforcing it here on a repo with 12 commits (with 7 characters still gives 78e9 combinations which assuming a repo has a thousand commits would mean a 1 in which even at 7 character is still 78e9 combinations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@boegelbot please test @ jsc-zen3 |
@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2027789603 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Going in, thanks @boegel! |
(created using
eb --new-pr
)