Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable detection of Dbus broker for at-spi2-core (+ bump at-spi2-core v2.49.90 to v2.49.91) #18727

Merged
merged 3 commits into from Sep 6, 2023

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Sep 6, 2023

Systems that have Dbus broker installed have this detected by at-spi2-core (which is an R dependency) and this has been seen to cause issues with builds.

@ocaisa
Copy link
Member Author

ocaisa commented Sep 6, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=18727 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18727 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11652

Test results coming soon (I hope)...

- notification for comment with ID 1707959256 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/88883a40df1564b2a67632dfe94fced3 for a full test report.

@ocaisa
Copy link
Member Author

ocaisa commented Sep 6, 2023

@boegelbot please test @ generoso

@ocaisa ocaisa added the bug fix label Sep 6, 2023
@ocaisa ocaisa added this to the next release (4.8.1?) milestone Sep 6, 2023
@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=18727 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18727 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11653

Test results coming soon (I hope)...

- notification for comment with ID 1707995629 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@ocaisa
Copy link
Member Author

ocaisa commented Sep 6, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18727 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18727 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3321

Test results coming soon (I hope)...

- notification for comment with ID 1708004300 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/5a3c0180619a86f33754077c2d87b5ac for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 9 out of 9 (7 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/faa3603d3e8377d1b65697bb28c59af3 for a full test report.

@verdurin
Copy link
Member

verdurin commented Sep 6, 2023

Test report by @verdurin
FAILED
Build succeeded for 6 out of 7 (7 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/2d7ff6c299615cbb8caa43444105aaa1 for a full test report.

@verdurin
Copy link
Member

verdurin commented Sep 6, 2023

My build failure:

[91/291] Linking target atspi/libatspi.so.0.0.1
FAILED: atspi/libatspi.so.0.0.1
gcc  -o atspi/libatspi.so.0.0.1 atspi/libatspi.so.0.0.1.p/meson-generated_.._atspi-enum-types.c.o atspi/libatspi.so.0.0.1.p/meson-generated_.._atspimarshal.c.o atspi/libatspi.so.0.0.1.p/atspi-accessible.c.o atspi/libatspi.so.0.0.1.p/atspi-action.c.o atspi/libatspi.so.0.0.1.p/atspi-application.c.o atspi/libatspi.so.0.0.1.p/atspi-collection.c.o atspi/libatspi.so.0.0.1.p/atspi-component.c.o atspi/libatspi.so.0.0.1.p/atspi-device.c.o atspi/libatspi.so.0.0.1.p/atspi-device-legacy.c.o atspi/libatspi.so.0.0.1.p/atspi-device-listener.c.o atspi/libatspi.so.0.0.1.p/atspi-document.c.o atspi/libatspi.so.0.0.1.p/atspi-editabletext.c.o atspi/libatspi.so.0.0.1.p/atspi-event-listener.c.o atspi/libatspi.so.0.0.1.p/atspi-gmain.c.o atspi/libatspi.so.0.0.1.p/atspi-hyperlink.c.o atspi/libatspi.so.0.0.1.p/atspi-hypertext.c.o atspi/libatspi.so.0.0.1.p/atspi-image.c.o atspi/libatspi.so.0.0.1.p/atspi-matchrule.c.o atspi/libatspi.so.0.0.1.p/atspi-misc.c.o atspi/libatspi.so.0.0.1.p/atspi-object.c.o atspi/libatspi.so.0.0.1.p/atspi-registry.c.o atspi/libatspi.so.0.0.1.p/atspi-relation.c.o atspi/libatspi.so.0.0.1.p/atspi-selection.c.o atspi/libatspi.so.0.0.1.p/atspi-stateset.c.o atspi/libatspi.so.0.0.1.p/atspi-table.c.o atspi/libatspi.so.0.0.1.p/atspi-table-cell.c.o atspi/libatspi.so.0.0.1.p/atspi-text.c.o atspi/libatspi.so.0.0.1.p/atspi-value.c.o atspi/libatspi.so.0.0.1.p/atspi-device-x11.c.o atspi/libatspi.so.0.0.1.p/.._dbind_dbind.c.o atspi/libatspi.so.0.0.1.p/.._dbind_dbind-any.c.o -L/eb/maint/software/X11/20230603-GCCcore-12.3.0/lib64 -L/eb/maint/software/X11/20230603-GCCcore-12.3.0/lib -L/eb/maint/software/DBus/1.15.4-GCCcore-12.3.0/lib64 -L/eb/maint/software/DBus/1.15.4-GCCcore-12.3.0/lib -L/eb/maint/software/GLib/2.77.1-GCCcore-12.3.0/lib64 -L/eb/maint/software/GLib/2.77.1-GCCcore-12.3.0/lib -L/eb/maint/software/pkgconf/1.9.5-GCCcore-12.3.0/lib64 -L/eb/maint/software/pkgconf/1.9.5-GCCcore-12.3.0/lib -L/eb/maint/software/gettext/0.21.1-GCCcore-12.3.0/lib64 -L/eb/maint/software/gettext/0.21.1-GCCcore-12.3.0/lib -L/eb/maint/software/GObject-Introspection/1.76.1-GCCcore-12.3.0/lib64 -L/eb/maint/software/GObject-Introspection/1.76.1-GCCcore-12.3.0/lib -L/eb/maint/software/Meson/1.1.1-GCCcore-12.3.0/lib64 -L/eb/maint/software/Meson/1.1.1-GCCcore-12.3.0/lib -L/eb/maint/software/binutils/2.40-GCCcore-12.3.0/lib64 -L/eb/maint/software/binutils/2.40-GCCcore-12.3.0/lib -L/eb/maint/software/GCCcore/12.3.0/lib64 -L/eb/maint/software/GCCcore/12.3.0/lib -I/eb/maint/software/X11/20230603-GCCcore-12.3.0/include -I/eb/maint/software/DBus/1.15.4-GCCcore-12.3.0/include -I/eb/maint/software/GLib/2.77.1-GCCcore-12.3.0/include -I/eb/maint/software/pkgconf/1.9.5-GCCcore-12.3.0/include -I/eb/maint/software/gettext/0.21.1-GCCcore-12.3.0/include -I/eb/maint/software/GObject-Introspection/1.76.1-GCCcore-12.3.0/include -I/eb/maint/software/binutils/2.40-GCCcore-12.3.0/include -Wl,--as-needed -Wl,--no-undefined -shared -fPIC -Wl,--start-group -Wl,-soname,libatspi.so.0 -O2 -ftree-vectorize -march=native -fno-math-errno /eb/maint/software/DBus/1.15.4-GCCcore-12.3.0/lib/libdbus-1.so /eb/maint/software/GLib/2.77.1-GCCcore-12.3.0/lib/libgobject-2.0.so /eb/maint/software/GLib/2.77.1-GCCcore-12.3.0/lib/libglib-2.0.so /eb/maint/software/X11/20230603-GCCcore-12.3.0/lib/libX11.so /eb/maint/software/X11/20230603-GCCcore-12.3.0/lib/libXtst.so /eb/maint/software/X11/20230603-GCCcore-12.3.0/lib/libXi.so -Wl,--end-group
/eb/maint/software/binutils/2.40-GCCcore-12.3.0/bin/ld: atspi/libatspi.so.0.0.1.p/atspi-device-legacy.c.o: in function `key_cb':
/dev/shm/atspi2core/2.49.90/GCCcore-12.3.0/easybuild_obj/../at-spi2-core-2.49.90/atspi/atspi-device-legacy.c:113: undefined reference to `timersub'
collect2: error: ld returned 1 exit status

@ocaisa
Copy link
Member Author

ocaisa commented Sep 6, 2023

Did you have a successful build before? Does this change trigger the error? For that particular version I've only set some configuration options so not sure what the impact could be.

@ocaisa
Copy link
Member Author

ocaisa commented Sep 6, 2023

The relevant lines of code were removed in a recent commit https://gitlab.gnome.org/GNOME/at-spi2-core/-/commit/e6f431beb47d2aadab7d2020e547e0b559557914

I guess I could try to add a patch (which is exactly what I was trying to avoid!)

@ocaisa
Copy link
Member Author

ocaisa commented Sep 6, 2023

Hmm, that version has not made it into an EB release yet, I could update it to the latest release and change the one place it appears as a dep

@ocaisa
Copy link
Member Author

ocaisa commented Sep 6, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=18727 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18727 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11655

Test results coming soon (I hope)...

- notification for comment with ID 1708457131 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@ocaisa
Copy link
Member Author

ocaisa commented Sep 6, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18727 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18727 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3323

Test results coming soon (I hope)...

- notification for comment with ID 1708458742 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@verdurin
Copy link
Member

verdurin commented Sep 6, 2023

Test report by @verdurin
SUCCESS
Build succeeded for 9 out of 9 (8 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/d31af970d0d3f25042e256c10258e0e2 for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/06d300155b77c0da235d631351a502c4 for a full test report.

@Micket
Copy link
Contributor

Micket commented Sep 6, 2023

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.7, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/1efe8584ef3ff5d7e60f29f518b6a72a for a full test report.

@boegel boegel changed the title Disable detection of Dbus broker for at-spi2-core disable detection of Dbus broker for at-spi2-core (+ bump at-spi2-core v2.49.90 to v2.49.91) Sep 6, 2023
@boegel boegel added the change label Sep 6, 2023
@ocaisa
Copy link
Member Author

ocaisa commented Sep 6, 2023

The test on generoso completed successfully but it didn't seem to upload the report, I'll retry

@ocaisa
Copy link
Member Author

ocaisa commented Sep 6, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=18727 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18727 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11657

Test results coming soon (I hope)...

- notification for comment with ID 1708541310 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Sep 6, 2023

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
node3109.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/cc6b373b60ab003770dc06dbb92223fe for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/4f007194e4ce629463f60121fa2ed731 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 6, 2023

Going in, thanks @ocaisa!

@boegel boegel merged commit 77586bd into easybuilders:develop Sep 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants