Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch to fix issue with automatic detection of NeoverseV1 CPU architecture in OpenBLAS v0.3.20 #18870

Merged

Conversation

casparvl
Copy link
Contributor

@casparvl casparvl commented Sep 26, 2023

(created using eb --new-pr)

edit (by @boegel): worth noting:

@casparvl
Copy link
Contributor Author

@boegelbot please test @ generoso

@boegel boegel added bug fix EESSI Related to EESSI project aarch64 Related to Arm 64-bit (aarch64) labels Sep 26, 2023
@boegel boegel added this to the next release (4.8.2?) milestone Sep 26, 2023
@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=18870 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_18870 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11777

Test results coming soon (I hope)...

- notification for comment with ID 1735921246 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel boegel changed the title Fixes issue with automatic detection of NeoverseV1 architecture at build time of OpenBLAS add patch to fix issue with automatic detection of NeoverseV1 CPU architecture in OpenBLAS v0.3.20 Sep 26, 2023
@casparvl
Copy link
Contributor Author

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18870 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18870 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3429

Test results coming soon (I hope)...

- notification for comment with ID 1735935148 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/a7d847f3316b68effe2d13f3d4501449 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/39e6c7d1c32e5cc739fedcf22e4462da for a full test report.

@casparvl
Copy link
Contributor Author

Test report by @casparvl
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/f6af8cd6d5bdfa0182ffa22be371b9a7 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 26, 2023

Test report by @boegel
SUCCESS
Build succeeded (with --ignore-test-failure) for 1 out of 1 (1 easyconfigs in total)
fair-mastodon-c7g-4xlarge-0001 - Linux Rocky Linux 8.7, AArch64, ARM UNKNOWN (neoverse_n1), Python 3.6.8
See https://gist.github.com/boegel/e86f26024b3362880062aa31c70ac88f for a full test report.

edit: this was tested with --ignore-test-failure because we see more non-numerical test failures for OpenBLAS on aarch64, see also EESSI/software-layer#314

boegel
boegel previously approved these changes Sep 26, 2023
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@easybuilders easybuilders deleted a comment from boegelbot Sep 26, 2023
@boegel
Copy link
Member

boegel commented Sep 26, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3157.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/02a7cb86d15b7898b7adf062e8a211df for a full test report.

@boegel
Copy link
Member

boegel commented Sep 26, 2023

Going in, thanks @casparvl!

@boegel boegel merged commit ce1b0ae into easybuilders:develop Sep 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to Arm 64-bit (aarch64) bug fix EESSI Related to EESSI project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants