Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts to archive easyconfigs #18934

Merged
merged 4 commits into from Oct 11, 2023
Merged

scripts to archive easyconfigs #18934

merged 4 commits into from Oct 11, 2023

Conversation

Micket
Copy link
Contributor

@Micket Micket commented Oct 6, 2023

edit: wopps wrong base branch, forgot to swap to 5.0.x

@Micket Micket added the EasyBuild-5.0 EasyBuild 5.0 label Oct 6, 2023
@Micket Micket force-pushed the archiving branch 3 times, most recently from 6e49a99 to e35d0d5 Compare October 6, 2023 18:23
@boegel boegel changed the title Archiving scripts scripts to archive easyconfigs Oct 9, 2023
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you run a linter on this, because the indentation is off in many places.

scripts/archive_old Outdated Show resolved Hide resolved
scripts/archive_toolchain Outdated Show resolved Hide resolved
scripts/archive_toolchain Outdated Show resolved Hide resolved
scripts/archive_old Outdated Show resolved Hide resolved
scripts/archive_old Outdated Show resolved Hide resolved
@smoors
Copy link
Contributor

smoors commented Oct 10, 2023

would it be more useful if, when archiving a toolchain, say foss-2018b, all subtoolchains were also archived?
in our site we're keeping a mapping that can help with this.
can also be done in a follow-up PR of course.

SUBTOOLCHAINS = { 
    '2023a': ['GCCcore-12.3.0', 'GCC-12.3.0', 'intel-compilers-2023.1.0'],
    '2022b': ['GCCcore-12.2.0', 'GCC-12.2.0', 'intel-compilers-2022.2.1'],
    '2022a': ['GCCcore-11.3.0', 'GCC-11.3.0', 'intel-compilers-2022.1.0'],
    '2021b': ['GCCcore-11.2.0', 'GCC-11.2.0', 'intel-compilers-2021.4.0'],
    '2021a': ['GCCcore-10.3.0', 'GCC-10.3.0', 'intel-compilers-2021.2.0'],
    '2020b': ['GCCcore-10.2.0', 'GCC-10.2.0', 'iccifort-2020.4.304'],
    '2020a': ['GCCcore-9.3.0', 'GCC-9.3.0', 'iccifort-2020.1.217'],
    '2019b': ['GCCcore-8.3.0', 'GCC-8.3.0', 'iccifort-2019.5.281'],
    '2019a': ['GCCcore-8.2.0', 'GCC-8.2.0-2.31.1', 'iccifort-2019.1.144-GCC-8.2.0-2.31.1'],
    '2018b': ['GCCcore-7.3.0', 'GCC-7.3.0-2.30', 'iccifort-2018.3.222-GCC-7.3.0-2.30'],
}

@Micket
Copy link
Contributor Author

Micket commented Oct 10, 2023

I was requested to split it up and not make it one big PR

@boegel boegel added this to the 5.0 milestone Oct 11, 2023
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors merged commit 4540441 into easybuilders:5.0.x Oct 11, 2023
5 checks passed
@Micket Micket deleted the archiving branch October 11, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EasyBuild-5.0 EasyBuild 5.0
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants