Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 'cstd': 'c++17' as this is default in GCC 11 for GLIMPSE #18944

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Oct 7, 2023

(created using eb --new-pr)

From https://gcc.gnu.org/projects/cxx-status.html#cxx17

C++17 mode is the default since GCC 11

@branfosj branfosj added this to the next release (4.8.2?) milestone Oct 7, 2023
@branfosj
Copy link
Member Author

branfosj commented Oct 7, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=18944 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_18944 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11884

Test results coming soon (I hope)...

- notification for comment with ID 1751671579 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Member Author

branfosj commented Oct 7, 2023

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0105u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/caed24613368a8656a4df98cdfb8ab62 for a full test report.

@branfosj branfosj changed the title remove 'cstd': 'c++17' as this is default in GCC 11 for GLIMPSE remove 'cstd': 'c++17' as this is default in GCC 11 for GLIMPSE Oct 7, 2023
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/68c68f9b2645f5c58df67355c76f87b7 for a full test report.

@branfosj
Copy link
Member Author

branfosj commented Oct 7, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18944 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18944 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3502

Test results coming soon (I hope)...

- notification for comment with ID 1751672949 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/1312d3f3b487d6b8a52615ffc8c99a25 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Oct 7, 2023

Going in, thanks @branfosj!

@boegel boegel merged commit b2b8f14 into easybuilders:develop Oct 7, 2023
5 checks passed
@branfosj branfosj deleted the 20231007110736_new_pr_GLIMPSE200 branch October 7, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants