Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch Pillow's setup.py rather than hardcoding system paths in $CPATH and $LIBRARY_PATH #19267

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 20, 2023

(created using eb --new-pr)

I don't like to add system paths to $CPATH and $LIBRARY_PATH, so implemented the suggestion I made in #19226

@boegel boegel added bug fix EESSI Related to EESSI project labels Nov 20, 2023
@boegel boegel added this to the next release (4.9.0?) milestone Nov 20, 2023
@boegel boegel requested a review from ocaisa November 20, 2023 14:45
@boegel boegel changed the title patch Pillow's setup.py rather than hardcoding system paths in $CPATH and $LIBRARY_PATH patch Pillow's setup.py rather than hardcoding system paths in $CPATH and $LIBRARY_PATH Nov 20, 2023
@ocaisa
Copy link
Member

ocaisa commented Nov 20, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19267 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19267 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3760

Test results coming soon (I hope)...

- notification for comment with ID 1819230494 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@ocaisa
Copy link
Member

ocaisa commented Nov 20, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=19267 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19267 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12196

Test results coming soon (I hope)...

- notification for comment with ID 1819239470 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 13 out of 13 (13 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/a98619d9b906bd3524ef43c2ba4ce42e for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 12 out of 14 (13 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/0220984899740dd224a57c0914182236 for a full test report.

@ocaisa
Copy link
Member

ocaisa commented Nov 20, 2023

Thanks for the update @boegel

@ocaisa ocaisa merged commit 68f6d93 into easybuilders:develop Nov 20, 2023
9 checks passed
@boegel boegel deleted the 20231120153412_new_pr_Pillow1000 branch November 20, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix EESSI Related to EESSI project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants