Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define $GTKDOCIZE as 'echo' before generating configure script for new HarfBuzz versions #19339

Merged

Conversation

Neves-P
Copy link
Contributor

@Neves-P Neves-P commented Nov 30, 2023

(created using eb --new-pr)

@Neves-P
Copy link
Contributor Author

Neves-P commented Nov 30, 2023

Test report by @Neves-P
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in total)
WKS058930 - Linux Ubuntu 22.04, x86_64, 12th Gen Intel(R) Core(TM) i7-1260P, Python 3.10.12
See https://gist.github.com/Neves-P/eb2691505e6051cab4fc90033768a489 for a full test report.

@Neves-P
Copy link
Contributor Author

Neves-P commented Nov 30, 2023

Test report by @Neves-P
SUCCESS
Build succeeded for 8 out of 8 (3 easyconfigs in total)
WKS058930 - Linux Ubuntu 22.04, x86_64, 12th Gen Intel(R) Core(TM) i7-1260P, Python 3.10.12
See https://gist.github.com/Neves-P/5f32362174e912da9314671a9a73bee0 for a full test report.

@bedroge
Copy link
Contributor

bedroge commented Nov 30, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=19339 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19339 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12315

Test results coming soon (I hope)...

- notification for comment with ID 1833780864 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/94eac1b4313ebe503db621d13bc7e3cc for a full test report.

@bedroge
Copy link
Contributor

bedroge commented Nov 30, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19339 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19339 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3835

Test results coming soon (I hope)...

- notification for comment with ID 1833810528 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/f7f38fa04e645c4ad3ddc74df623b0c9 for a full test report.

@bedroge bedroge added bug fix EESSI Related to EESSI project labels Nov 30, 2023
@bedroge bedroge changed the title Also apply same as #16570 in newer versions of HarfBuzz define $GTKDOCIZE as 'echo' before generating configure script for new HarfBuzz versions Nov 30, 2023
Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, and solved the issue in the EESSI environment (see EESSI/software-layer#406).

@bedroge bedroge added this to the next release (4.9.0?) milestone Nov 30, 2023
@bedroge
Copy link
Contributor

bedroge commented Nov 30, 2023

Going in, thanks @Neves-P!

@bedroge bedroge merged commit 42319ad into easybuilders:develop Nov 30, 2023
9 checks passed
@Neves-P Neves-P deleted the 20231130133332_new_pr_HarfBuzz531 branch February 19, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix EESSI Related to EESSI project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants