Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace parallel by maxparallel #19375

Open
wants to merge 1 commit into
base: 5.0.x
Choose a base branch
from

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Dec 7, 2023

The latter is the new, better option which makes it clear how it works with --parallel passed in the config or commandline.

5.x target of #19374 required by easybuilders/easybuild-framework#4398

Note: CI fails for unrelated reasons and fixing all those ECs is unfeasible, so I'd suggest to bite the bullet and merge this even though CI fails.

@Flamefire
Copy link
Contributor Author

@boegel Resolved conflicts

@boegelbot
Copy link
Collaborator

@Flamefire: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/7421645944
Output from first failing test suite run:

FAIL: test_pr_CMAKE_BUILD_TYPE (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure -DCMAKE_BUILD_TYPE is no longer used (replaced by build_type)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1278, in test_pr_CMAKE_BUILD_TYPE
    self.fail('\n'.join(failing_checks))
AssertionError: build_type was set to the default of 'Release'. Omit this to base it on toolchain_opts.debug: kim-api-2.3.0-GCC-11.2.0.eb
build_type was set to the default of 'Release'. Omit this to base it on toolchain_opts.debug: kim-api-2.3.0-GCC-11.3.0.eb

----------------------------------------------------------------------
Ran 8672 tests in 342.400s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@boegel boegel added change EasyBuild-5.0 EasyBuild 5.0 labels Jan 22, 2024
@boegel boegel added this to the 5.0 milestone Jan 22, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jan 22, 2024
@Flamefire
Copy link
Contributor Author

Rebased and updated. Let's see what CI says ;-)

@boegelbot
Copy link
Collaborator

@Flamefire: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/8078615944
Output from first failing test suite run:

FAIL: test_pr_CMAKE_BUILD_TYPE (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure -DCMAKE_BUILD_TYPE is no longer used (replaced by build_type)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1317, in test_pr_CMAKE_BUILD_TYPE
    self.fail('\n'.join(failing_checks))
AssertionError: build_type was set to the default of 'Release'. Omit this to base it on toolchain_opts.debug: kim-api-2.3.0-GCC-11.2.0.eb
build_type was set to the default of 'Release'. Omit this to base it on toolchain_opts.debug: kim-api-2.3.0-GCC-11.3.0.eb

----------------------------------------------------------------------
Ran 9039 tests in 353.192s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

The latter is the new, better option which makes it clear how it works
with `--parallel` passed in the config or commandline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants