Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong handling of floats in z3-solver #19414

Merged

Conversation

Flamefire
Copy link
Contributor

(created using eb --new-pr)

@jfgrimm
Copy link
Member

jfgrimm commented Dec 13, 2023

@boegelbot: please test @ generoso

@jfgrimm jfgrimm added this to the next release (4.9.0?) milestone Dec 13, 2023
@boegelbot
Copy link
Collaborator

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=19414 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19414 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12395

Test results coming soon (I hope)...

- notification for comment with ID 1854222078 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6468574a4e8095391de0c2f1e2c7568e for a full test report.

@jfgrimm
Copy link
Member

jfgrimm commented Dec 13, 2023

@boegelbot: please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@jfgrimm: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19414 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19414 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3904

Test results coming soon (I hope)...

- notification for comment with ID 1854265106 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@jfgrimm
Copy link
Member

jfgrimm commented Dec 13, 2023

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node034.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/e36f36d7588b4801d9cbd96cbfd7e2bd for a full test report.

Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/fd9056632f47f4d578cfb2f34a732d11 for a full test report.

@jfgrimm
Copy link
Member

jfgrimm commented Dec 13, 2023

Going in, thanks @Flamefire!

@jfgrimm jfgrimm merged commit 2a80ea7 into easybuilders:develop Dec 13, 2023
9 checks passed
@Flamefire Flamefire deleted the 20231213165424_new_pr_Z34102 branch December 13, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants