Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add patch for Arrow v8.0.0 - v11.0.0 to add missing __arrow_ext_class__ method to BaseExtensionType class #19532

Merged
merged 4 commits into from Jan 10, 2024
Merged

add patch for Arrow v8.0.0 - v11.0.0 to add missing __arrow_ext_class__ method to BaseExtensionType class #19532

merged 4 commits into from Jan 10, 2024

Conversation

PetrKralCZ
Copy link
Collaborator

(created using eb --new-pr)

@PetrKralCZ PetrKralCZ changed the title bug fix Arrow 8.0.0 - 11.0.0 bug fix Jan 9, 2024
@PetrKralCZ PetrKralCZ mentioned this pull request Jan 9, 2024
Closed
@boegel boegel changed the title Arrow 8.0.0 - 11.0.0 bug fix add patch for Arrow v8.0.0 - v11.0.0 to add missing __arrow_ext_class__ method to BaseExtensionType class Jan 9, 2024
boegel
boegel requested changes Jan 9, 2024
View reviewed changes
easybuild/easyconfigs/a/Arrow/Arrow-11.0.0-gfbf-2022b.eb Outdated
@@ -11,7 +11,11 @@ toolchain = {'name': 'gfbf', 'version': '2022b'}

source_urls = ['https://archive.apache.org/dist/%(namelower)s/%(namelower)s-%(version)s']
sources = ['apache-arrow-%(version)s.tar.gz']
checksums = ['2dd8f0ea0848a58785628ee3a57675548d509e17213a2f5d72b0d900b43f5430']
patches = ['Arrow-8.0.0_bugfix.patch']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrKralCZ The patch filename should be a bit more descriptive, "bugfix" is way too generic.

How about Arrow-8.0.0_fix-BaseExtensionType-arrow-ext-methods.patch

easybuild/easyconfigs/a/Arrow/Arrow-8.0.0_bugfix.patch Outdated Show resolved Hide resolved
@boegel boegel added the bug fix label Jan 9, 2024
@boegel boegel added this to the release after 4.9.0 milestone Jan 9, 2024
@PetrKralCZ
Copy link
Collaborator Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@PetrKralCZ: Request for testing this PR well received on login1

PR test command 'EB_PR=19532 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19532 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12556

Test results coming soon (I hope)...

- notification for comment with ID 1884502941 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 3 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/3ffdcf1fbd5977c0097bc4c09be1e621 for a full test report.

@boegel
Copy link
Member

boegel commented Jan 10, 2024

Test report by @boegel
FAILED
Build succeeded for 3 out of 4 (4 easyconfigs in total)
node3157.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/5253922be81da89b7f43781946c6747d for a full test report.

boegel
boegel requested changes Jan 10, 2024
View reviewed changes
easybuild/easyconfigs/a/Arrow/Arrow-11.0.0-gfbf-2022b.eb Outdated
checksums = ['2dd8f0ea0848a58785628ee3a57675548d509e17213a2f5d72b0d900b43f5430']
patches = ['Arrow-8.0.0_fix-BaseExtensionType-arrow-ext-methods.patch']
checksums = [
{'apache-arrow-8.0.0.tar.gz': 'ad9a05705117c989c116bae9ac70492fe015050e1b80fb0e38fde4b5d863aaa3'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrKralCZ This should be fixed, for 11.0.0

@boegel
Copy link
Member

boegel commented Jan 10, 2024

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19532 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19532 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4035

Test results coming soon (I hope)...

- notification for comment with ID 1884913664 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Jan 10, 2024

@boegelbot please test @ generoso
EB_ARGS="Arrow-11.0.0-gfbf-2022b.eb"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19532 EB_ARGS="Arrow-11.0.0-gfbf-2022b.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19532 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12560

Test results coming soon (I hope)...

- notification for comment with ID 1884933717 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Jan 10, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3157.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/ad22a2d62ab34ceecf1e4bd90d570767 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/1630b600fce6c6a9a171280e3fb3bc3e for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (4 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/9ec5ec32308ae64b1d94394c5d41d315 for a full test report.

boegel
boegel approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 10, 2024

Going in, thanks @PetrKralCZ!

@boegel boegel merged commit 13443af into easybuilders:develop Jan 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.9.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PetrKralCZ @boegelbot @boegel