New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move setuptools_scm
from hatchling
to Python easyconfig
#19651
move setuptools_scm
from hatchling
to Python easyconfig
#19651
Conversation
@boegelbot: please test @ generoso |
@lexming: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1900672039 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen3 |
@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1903678545 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
setuptools_scm
from hatchling
to Python easyconfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegel |
Going in, thanks @lexming! |
(created using
eb --new-pr
)There is software that uses
setuptools_scm
withouthatchling
. In those cases the build will not fail, but generate packages with version0.0.0
.Example is
mapclassify
, see https://github.com/pysal/mapclassify/blob/9953271bcc90ffb4e6c54d3c5a0ff48010dcb9be/pyproject.toml#L2Therefore, I propose to ship
setuptools_scm
together withsetuptools
in the base easyconfig of Python.