Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move setuptools_scm from hatchling to Python easyconfig #19651

Merged
merged 3 commits into from Jan 22, 2024

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Jan 19, 2024

(created using eb --new-pr)

There is software that uses setuptools_scm without hatchling. In those cases the build will not fail, but generate packages with version 0.0.0.

Example is mapclassify, see https://github.com/pysal/mapclassify/blob/9953271bcc90ffb4e6c54d3c5a0ff48010dcb9be/pyproject.toml#L2

Therefore, I propose to ship setuptools_scm together with setuptools in the base easyconfig of Python.

@lexming lexming added the change label Jan 19, 2024
@lexming
Copy link
Contributor Author

lexming commented Jan 19, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=19651 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19651 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12671

Test results coming soon (I hope)...

- notification for comment with ID 1900672039 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/5a826f38187c64b65d2bc7443ffe6289 for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Jan 22, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19651 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19651 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3445

Test results coming soon (I hope)...

- notification for comment with ID 1903678545 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/4d91b224a406001607379c80543a5443 for a full test report.

boegel
boegel previously approved these changes Jan 22, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lexming lexming changed the base branch from develop to 5.0.x January 22, 2024 15:55
@lexming lexming dismissed boegel’s stale review January 22, 2024 15:55

The base branch was changed.

@boegel boegel changed the title move setuptools_scm from hatchling to Python easyconfig move setuptools_scm from hatchling to Python easyconfig Jan 22, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 22, 2024

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3129.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/ed933aa0a3ac512131adc9bad8b98c77 for a full test report.

@boegel
Copy link
Member

boegel commented Jan 22, 2024

Going in, thanks @lexming!

@boegel boegel merged commit 0564592 into easybuilders:5.0.x Jan 22, 2024
7 checks passed
@lexming lexming deleted the 20240119163553_new_pr_Python3113 branch January 23, 2024 09:01
@lexming lexming added the EasyBuild-5.0 EasyBuild 5.0 label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants